There is a memory leak

2023-11-30 11:51:53 +01:00
parent d1475d506e
commit 1493627ceb
20 changed files with 91 additions and 102 deletions
@@ -14,8 +14,7 @@ struct DirectionalLight : ILightEnv

    float3 illuminate<B:IBRDF>(LightingParameter params, B brdf)
    {
-        float3 lightDir_TS = mul(params.tbn, normalize(direction.xyz));
-        return brdf.evaluate(params.viewDir_TS, -lightDir_TS, color.xyz);
+        return brdf.evaluate(params.tbn, params.viewDir_WS, -normalize(direction.xyz), color.xyz);
    }
 };

@@ -26,11 +25,10 @@ struct PointLight : ILightEnv
    
    float3 illuminate<B:IBRDF>(LightingParameter params, B brdf)
    {
-        float3 position_TS = mul(params.tbn, position_WS.xyz);
-        float3 lightDir_TS = position_TS - params.position_TS;
-        float d = length(lightDir_TS);
+        float3 lightDir_WS = position_WS.xyz - params.position_WS;
+        float d = length(lightDir_WS);
        float illuminance = max(1 - d / colorRange.w, 0);
-        return illuminance * brdf.evaluate(params.viewDir_TS, normalize(lightDir_TS), colorRange.xyz);
+        return brdf.evaluate(params.tbn, params.viewDir_WS, normalize(lightDir_WS), colorRange.xyz);
    }

    bool insidePlane(Plane plane)