Adding benchmark

src/Engine/Asset/TextureAsset.cpp

@@ -5,7 +5,6 @@
 #include "Window/WindowManager.h"
 #include "ktx.h"
 
-
 using namespace Seele;
 
 #define KTX_ASSERT(x)                                                                                                                      \
@@ -24,35 +23,17 @@ TextureAsset::TextureAsset(std::string_view folderPath, std::string_view name) :
 TextureAsset::~TextureAsset() {}
 
 void TextureAsset::save(ArchiveBuffer& buffer) const {
-    // ktxBasisParams basisParams = {
-    //     .structSize = sizeof(ktxBasisParams),
-    //     .uastc = true,
-    //     .threadCount = std::thread::hardware_concurrency(),
-    //     .normalMap = normalMap,
-    //     .uastcFlags = KTX_PACK_UASTC_LEVEL_VERYSLOW,
-    //     .uastcRDO = true,
-    //     .uastcRDOQualityScalar = 1,
-    // };
-    // KTX_ASSERT(ktxTexture2_CompressBasisEx(ktxHandle, &basisParams));
-    // KTX_ASSERT(ktxTexture2_DeflateZstd(ktxHandle, 20));
-    // ktx_uint8_t* texData;
-    // ktx_size_t texSize;
-    // KTX_ASSERT(ktxTexture_WriteToMemory(ktxTexture(ktxHandle), &texData, &texSize));
-    //
-    // Array<uint8> rawData(texSize);
-    // std::memcpy(rawData.data(), texData, texSize);
-    // Serialization::save(buffer, rawData);
-    // free(texData);
+    Serialization::save(buffer, ktxData);
 }
 
 void TextureAsset::load(ArchiveBuffer& buffer) {
-    std::string ktxPath;
-    Serialization::load(buffer, ktxPath);
     ktxTexture2* ktxHandle;
+    Serialization::load(buffer, ktxData);
+    KTX_ASSERT(
+        ktxTexture_CreateFromMemory(ktxData.data(), ktxData.size(), KTX_TEXTURE_CREATE_LOAD_IMAGE_DATA_BIT, (ktxTexture**)&ktxHandle));
 
-    KTX_ASSERT(ktxTexture_CreateFromNamedFile(ktxPath.c_str(), KTX_TEXTURE_CREATE_NO_FLAGS, (ktxTexture**)&ktxHandle));
-
-    KTX_ASSERT(ktxTexture2_TranscodeBasis(ktxHandle, KTX_TTF_BC7_RGBA, 0));
+    ktxTexture2_TranscodeBasis(ktxHandle, KTX_TTF_RGBA32, 0);
+    //ktxTexture2_DeflateZstd(ktxHandle, 0);
 
     Gfx::PGraphics graphics = buffer.getGraphics();
     TextureCreateInfo createInfo = {
@@ -60,7 +41,7 @@ void TextureAsset::load(ArchiveBuffer& buffer) {
             {
                 .size = ktxTexture_GetDataSize(ktxTexture(ktxHandle)),
                 .data = ktxTexture_GetData(ktxTexture(ktxHandle)),
-                .owner = Gfx::QueueType::TRANSFER,
+                .owner = Gfx::QueueType::GRAPHICS,
             },
         .format = (Gfx::SeFormat)ktxHandle->vkFormat,
         .width = ktxHandle->baseWidth,
@@ -79,12 +60,9 @@ void TextureAsset::load(ArchiveBuffer& buffer) {
         texture = graphics->createTexture2D(createInfo);
     }
 
-    texture->transferOwnership(Gfx::QueueType::GRAPHICS);
     ktxTexture_Destroy(ktxTexture(ktxHandle));
 }
 
-void TextureAsset::setTexture(Gfx::OTexture _texture) { texture = std::move(_texture); }
-
 uint32 TextureAsset::getWidth() { return texture->getWidth(); }
 
 uint32 TextureAsset::getHeight() { return texture->getHeight(); }

src/Engine/Asset/TextureAsset.h

@@ -12,14 +12,14 @@ class TextureAsset : public Asset {
     virtual ~TextureAsset();
     virtual void save(ArchiveBuffer& buffer) const override;
     virtual void load(ArchiveBuffer& buffer) override;
-    void setTexture(Gfx::OTexture _texture);
     Gfx::PTexture getTexture() { return texture; }
+    void setTexture(Array<uint8> data) { ktxData = std::move(data); }
     uint32 getWidth();
     uint32 getHeight();
 
   private:
     Gfx::OTexture texture;
-    bool normalMap;
+    Array<uint8> ktxData;
     friend class TextureLoader;
 };
 DEFINE_REF(TextureAsset)

src/Engine/Graphics/Query.h

@@ -51,7 +51,7 @@ class PipelineStatisticsQuery {
 DEFINE_REF(PipelineStatisticsQuery)
 struct Timestamp {
     std::string name;
-    std::chrono::nanoseconds time;
+    uint64 time;
 };
 class TimestampQuery {
   public:

src/Engine/Graphics/RenderPass/BasePass.cpp

@@ -1,5 +1,6 @@
 #include "BasePass.h"
 #include "Actor/CameraActor.h"
+#include "Asset/AssetRegistry.h"
 #include "Component/Camera.h"
 #include "Component/Mesh.h"
 #include "Graphics/Command.h"
@@ -7,6 +8,7 @@
 #include "Graphics/Enums.h"
 #include "Graphics/Graphics.h"
 #include "Graphics/Initializer.h"
+#include "Graphics/Pipeline.h"
 #include "Graphics/Shader.h"
 #include "Graphics/StaticMeshVertexData.h"
 #include "Material/MaterialInstance.h"
@@ -16,6 +18,12 @@
 
 using namespace Seele;
 
+Array<DebugVertex> gDebugVertices;
+
+void Seele::addDebugVertex(DebugVertex vert) { gDebugVertices.add(vert); }
+
+void Seele::addDebugVertices(Array<DebugVertex> verts) { gDebugVertices.addAll(verts); }
+
 BasePass::BasePass(Gfx::PGraphics graphics, PScene scene) : RenderPass(graphics, scene) {
     basePassLayout = graphics->createPipelineLayout("BasePassLayout");
 
@@ -68,6 +76,12 @@ BasePass::BasePass(Gfx::PGraphics graphics, PScene scene) : RenderPass(graphics,
                                                                           .useVisibility = false,
                                                                       });
     }
+    skybox = Seele::Component::Skybox{
+        .day = AssetRegistry::findTexture("", "skyboxsun5deg_tn")->getTexture().cast<Gfx::TextureCube>(),
+        .night = AssetRegistry::findTexture("", "skyboxsun5deg_tn")->getTexture().cast<Gfx::TextureCube>(),
+        .fogColor = Vector(0.1, 0.1, 0.8),
+        .blendFactor = 0,
+    };
 }
 
 BasePass::~BasePass() {}
@@ -81,6 +95,41 @@ void BasePass::beginFrame(const Component::Camera& cam) {
     lightCullingLayout->reset();
     opaqueCulling = lightCullingLayout->allocateDescriptorSet();
     transparentCulling = lightCullingLayout->allocateDescriptorSet();
+
+    // Debug vertices
+    VertexBufferCreateInfo vertexBufferInfo = {
+        .sourceData =
+            {
+                .size = sizeof(DebugVertex) * gDebugVertices.size(),
+                .data = (uint8*)gDebugVertices.data(),
+            },
+        .vertexSize = sizeof(DebugVertex),
+        .numVertices = (uint32)gDebugVertices.size(),
+        .name = "DebugVertices",
+    };
+    debugVertices = graphics->createVertexBuffer(vertexBufferInfo);
+    debugVertices->pipelineBarrier(Gfx::SE_ACCESS_TRANSFER_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT,
+                                   Gfx::SE_ACCESS_VERTEX_ATTRIBUTE_READ_BIT, Gfx::SE_PIPELINE_STAGE_VERTEX_INPUT_BIT);
+
+    // Skybox
+    skyboxDataLayout->reset();
+    textureLayout->reset();
+    skyboxData.transformMatrix = glm::rotate(skyboxData.transformMatrix, (float)(Gfx::getCurrentFrameDelta()), Vector(0, 1, 0));
+    skyboxBuffer->rotateBuffer(sizeof(SkyboxData));
+    skyboxBuffer->updateContents(DataSource{
+        .size = sizeof(SkyboxData),
+        .data = (uint8*)&skyboxData,
+    });
+    skyboxDataSet = skyboxDataLayout->allocateDescriptorSet();
+    skyboxDataSet->updateBuffer(0, skyboxBuffer);
+    skyboxDataSet->writeChanges();
+    skyboxBuffer->pipelineBarrier(Gfx::SE_ACCESS_TRANSFER_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT, Gfx::SE_ACCESS_UNIFORM_READ_BIT,
+                                  Gfx::SE_PIPELINE_STAGE_FRAGMENT_SHADER_BIT);
+    textureSet = textureLayout->allocateDescriptorSet();
+    textureSet->updateTexture(0, skybox.day);
+    textureSet->updateTexture(1, skybox.night);
+    textureSet->updateSampler(2, skyboxSampler);
+    textureSet->writeChanges();
 }
 
 void BasePass::render() {
@@ -95,7 +144,6 @@ void BasePass::render() {
     timestamps->write(Gfx::SE_PIPELINE_STAGE_TOP_OF_PIPE_BIT, "BASEPASS");
     graphics->beginRenderPass(renderPass);
     Array<Gfx::ORenderCommand> commands;
-
     Gfx::ShaderPermutation permutation = graphics->getShaderCompiler()->getTemplate("BasePass");
     permutation.setDepthCulling(true); // always use the culling info
     permutation.setPositionOnly(false);
@@ -193,110 +241,137 @@ void BasePass::render() {
             commands.add(std::move(command));
         }
     }
+
     graphics->executeCommands(std::move(commands));
 
-    Map<float, VertexData::TransparentDraw> sortedDraws;
-    for (const auto& t : transparentData) {
-        Vector toCenter = Vector(t.worldPosition) - cameraPos;
-        float dist = glm::length(toCenter) * glm::dot(glm::normalize(toCenter), cameraForward);
-        sortedDraws[dist] = t;
+    commands.clear();
+    // Transparent rendering
+    {
+        Map<float, VertexData::TransparentDraw> sortedDraws;
+        for (const auto& t : transparentData) {
+            Vector toCenter = Vector(t.worldPosition) - cameraPos;
+            float dist = glm::length(toCenter) * glm::dot(glm::normalize(toCenter), cameraForward);
+            sortedDraws[dist] = t;
+        }
+        Gfx::ORenderCommand transparentCommand = graphics->createRenderCommand("TransparentDraw");
+        transparentCommand->setViewport(viewport);
+        for (const auto& [_, t] : sortedDraws) {
+            permutation.setVertexData(t.vertexData->getTypeName());
+            permutation.setMaterial(t.matInst->getBaseMaterial()->getName());
+            Gfx::PermutationId id(permutation);
+
+            const Gfx::ShaderCollection* collection = graphics->getShaderCompiler()->findShaders(id);
+            assert(collection != nullptr);
+
+            bool twoSided = t.matInst->getBaseMaterial()->isTwoSided();
+
+            if (graphics->supportMeshShading()) {
+                Gfx::MeshPipelineCreateInfo pipelineInfo = {
+                    .taskShader = collection->taskShader,
+                    .meshShader = collection->meshShader,
+                    .fragmentShader = collection->fragmentShader,
+                    .renderPass = renderPass,
+                    .pipelineLayout = collection->pipelineLayout,
+                    .multisampleState =
+                        {
+                            .samples = viewport->getSamples(),
+                        },
+                    .rasterizationState =
+                        {
+                            .cullMode = Gfx::SeCullModeFlags(twoSided ? Gfx::SE_CULL_MODE_NONE : Gfx::SE_CULL_MODE_BACK_BIT),
+                        },
+                    .depthStencilState =
+                        {
+                            .depthCompareOp = Gfx::SE_COMPARE_OP_GREATER_OR_EQUAL,
+                        },
+                    .colorBlend =
+                        {
+                            .attachmentCount = 1,
+                            .blendAttachments =
+                                {
+                                    Gfx::ColorBlendState::BlendAttachment{
+                                        .blendEnable = true,
+                                    },
+                                },
+                        },
+                };
+                Gfx::PGraphicsPipeline pipeline = graphics->createGraphicsPipeline(std::move(pipelineInfo));
+                transparentCommand->bindPipeline(pipeline);
+            } else {
+                Gfx::LegacyPipelineCreateInfo pipelineInfo = {
+                    .vertexShader = collection->vertexShader,
+                    .fragmentShader = collection->fragmentShader,
+                    .renderPass = renderPass,
+                    .pipelineLayout = collection->pipelineLayout,
+                    .multisampleState =
+                        {
+                            .samples = viewport->getSamples(),
+                        },
+                    .rasterizationState =
+                        {
+                            .cullMode = Gfx::SeCullModeFlags(twoSided ? Gfx::SE_CULL_MODE_NONE : Gfx::SE_CULL_MODE_BACK_BIT),
+                        },
+                    .depthStencilState =
+                        {
+                            .depthCompareOp = Gfx::SE_COMPARE_OP_GREATER_OR_EQUAL,
+                        },
+                    .colorBlend =
+                        {
+                            .attachmentCount = 1,
+                            .blendAttachments =
+                                {
+                                    Gfx::ColorBlendState::BlendAttachment{
+                                        .blendEnable = true,
+                                    },
+                                },
+                        },
+                };
+                Gfx::PGraphicsPipeline pipeline = graphics->createGraphicsPipeline(std::move(pipelineInfo));
+                transparentCommand->bindPipeline(pipeline);
+            }
+            transparentCommand->bindDescriptor({viewParamsSet, t.vertexData->getVertexDataSet(), t.vertexData->getInstanceDataSet(),
+                                                scene->getLightEnvironment()->getDescriptorSet(), Material::getDescriptorSet(),
+                                                transparentCulling});
+            transparentCommand->pushConstants(Gfx::SE_SHADER_STAGE_TASK_BIT_EXT | Gfx::SE_SHADER_STAGE_VERTEX_BIT |
+                                                  Gfx::SE_SHADER_STAGE_FRAGMENT_BIT,
+                                              0, sizeof(VertexData::DrawCallOffsets), &t.offsets);
+            if (graphics->supportMeshShading()) {
+                transparentCommand->drawMesh(1, 1, 1);
+            } else {
+                // command->bindIndexBuffer(t.vertexData->getIndexBuffer());
+                // for (const auto& meshData : drawCall.instanceMeshData) {
+                //     // all meshlets of a mesh share the same indices offset
+                //     command->drawIndexed(meshData.numIndices, 1, meshData.firstIndex,
+                //     vertexData->getIndicesOffset(meshData.meshletOffset), 0);
+                // }
+            }
+        }
+        commands.add(std::move(transparentCommand));
     }
-    Gfx::ORenderCommand command = graphics->createRenderCommand("TransparentDraw");
-    command->setViewport(viewport);
-    for (const auto& [_, t] : sortedDraws) {
-        permutation.setVertexData(t.vertexData->getTypeName());
-        permutation.setMaterial(t.matInst->getBaseMaterial()->getName());
-        Gfx::PermutationId id(permutation);
-
-        const Gfx::ShaderCollection* collection = graphics->getShaderCompiler()->findShaders(id);
-        assert(collection != nullptr);
-
-        bool twoSided = t.matInst->getBaseMaterial()->isTwoSided();
-
-        if (graphics->supportMeshShading()) {
-            Gfx::MeshPipelineCreateInfo pipelineInfo = {
-                .taskShader = collection->taskShader,
-                .meshShader = collection->meshShader,
-                .fragmentShader = collection->fragmentShader,
-                .renderPass = renderPass,
-                .pipelineLayout = collection->pipelineLayout,
-                .multisampleState =
-                    {
-                        .samples = viewport->getSamples(),
-                    },
-                .rasterizationState =
-                    {
-                        .cullMode = Gfx::SeCullModeFlags(twoSided ? Gfx::SE_CULL_MODE_NONE : Gfx::SE_CULL_MODE_BACK_BIT),
-                    },
-                .depthStencilState =
-                    {
-                        .depthCompareOp = Gfx::SE_COMPARE_OP_GREATER_OR_EQUAL,
-                    },
-                .colorBlend =
-                    {
-                        .attachmentCount = 1,
-                        .blendAttachments =
-                            {
-                                Gfx::ColorBlendState::BlendAttachment{
-                                    .blendEnable = true,
-                                },
-                            },
-                    },
-            };
-            Gfx::PGraphicsPipeline pipeline = graphics->createGraphicsPipeline(std::move(pipelineInfo));
-            command->bindPipeline(pipeline);
-        } else {
-            Gfx::LegacyPipelineCreateInfo pipelineInfo = {
-                .vertexShader = collection->vertexShader,
-                .fragmentShader = collection->fragmentShader,
-                .renderPass = renderPass,
-                .pipelineLayout = collection->pipelineLayout,
-                .multisampleState =
-                    {
-                        .samples = viewport->getSamples(),
-                    },
-                .rasterizationState =
-                    {
-                        .cullMode = Gfx::SeCullModeFlags(twoSided ? Gfx::SE_CULL_MODE_NONE : Gfx::SE_CULL_MODE_BACK_BIT),
-                    },
-                .depthStencilState =
-                    {
-                        .depthCompareOp = Gfx::SE_COMPARE_OP_GREATER_OR_EQUAL,
-                    },
-                .colorBlend =
-                    {
-                        .attachmentCount = 1,
-                        .blendAttachments =
-                            {
-                                Gfx::ColorBlendState::BlendAttachment{
-                                    .blendEnable = true,
-                                },
-                            },
-                    },
-            };
-            Gfx::PGraphicsPipeline pipeline = graphics->createGraphicsPipeline(std::move(pipelineInfo));
-            command->bindPipeline(pipeline);
-        }
-        command->bindDescriptor({viewParamsSet, t.vertexData->getVertexDataSet(), t.vertexData->getInstanceDataSet(),
-                                 scene->getLightEnvironment()->getDescriptorSet(), Material::getDescriptorSet(), transparentCulling});
-        command->pushConstants(Gfx::SE_SHADER_STAGE_TASK_BIT_EXT | Gfx::SE_SHADER_STAGE_VERTEX_BIT | Gfx::SE_SHADER_STAGE_FRAGMENT_BIT, 0,
-                               sizeof(VertexData::DrawCallOffsets), &t.offsets);
-        if (graphics->supportMeshShading()) {
-            command->drawMesh(1, 1, 1);
-        } else {
-            // command->bindIndexBuffer(t.vertexData->getIndexBuffer());
-            // for (const auto& meshData : drawCall.instanceMeshData) {
-            //     // all meshlets of a mesh share the same indices offset
-            //     command->drawIndexed(meshData.numIndices, 1, meshData.firstIndex, vertexData->getIndicesOffset(meshData.meshletOffset),
-            //     0);
-            // }
-        }
+    // Debug vertices
+    if (gDebugVertices.size() > 0) {
+        Gfx::ORenderCommand debugCommand = graphics->createRenderCommand("DebugRender");
+        debugCommand->setViewport(viewport);
+        debugCommand->bindPipeline(debugPipeline);
+        debugCommand->bindDescriptor(viewParamsSet);
+        debugCommand->bindVertexBuffer({debugVertices});
+        debugCommand->draw((uint32)gDebugVertices.size(), 1, 0, 0);
+        commands.add(std::move(debugCommand));
     }
 
+    Gfx::ORenderCommand skyboxCommand = graphics->createRenderCommand("SkyboxRender");
+    skyboxCommand->setViewport(viewport);
+    skyboxCommand->bindPipeline(pipeline);
+    skyboxCommand->bindDescriptor({viewParamsSet, skyboxDataSet, textureSet});
+    skyboxCommand->draw(36, 1, 0, 0);
+
+    commands.add(std::move(skyboxCommand));
+    graphics->executeCommands(std::move(commands));
     graphics->endRenderPass();
     query->endQuery();
     timestamps->write(Gfx::SE_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT, "END");
     timestamps->end();
+    gDebugVertices.clear();
 }
 
 void BasePass::endFrame() {}
@@ -306,17 +381,44 @@ void BasePass::publishOutputs() {
         .format = Gfx::SE_FORMAT_D32_SFLOAT,
         .width = viewport->getOwner()->getFramebufferWidth(),
         .height = viewport->getOwner()->getFramebufferHeight(),
-        .samples = viewport->getSamples(),
         .usage = Gfx::SE_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT,
     };
     basePassDepth = graphics->createTexture2D(depthBufferInfo);
 
-    colorAttachment = Gfx::RenderTargetAttachment(viewport, Gfx::SE_IMAGE_LAYOUT_UNDEFINED, Gfx::SE_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL,
-                                                  Gfx::SE_ATTACHMENT_LOAD_OP_CLEAR, Gfx::SE_ATTACHMENT_STORE_OP_STORE);
-    resources->registerRenderPassOutput("BASEPASS_COLOR", colorAttachment);
+    TextureCreateInfo msDepthInfo = {
+        .format = Gfx::SE_FORMAT_D32_SFLOAT,
+        .width = viewport->getOwner()->getFramebufferWidth(),
+        .height = viewport->getOwner()->getFramebufferHeight(),
+        .samples = viewport->getSamples(),
+        .usage = Gfx::SE_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | Gfx::SE_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT,
+    };
+    msBasePassDepth = graphics->createTexture2D(msDepthInfo);
+
+    TextureCreateInfo msBaseColorInfo = {
+        .format = viewport->getOwner()->getSwapchainFormat(),
+        .width = viewport->getOwner()->getFramebufferWidth(),
+        .height = viewport->getOwner()->getFramebufferHeight(),
+        .samples = viewport->getSamples(),
+        .usage = Gfx::SE_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | Gfx::SE_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT,
+    };
+    msBasePassColor = graphics->createTexture2D(msBaseColorInfo);
+
     depthAttachment =
         Gfx::RenderTargetAttachment(basePassDepth, Gfx::SE_IMAGE_LAYOUT_UNDEFINED, Gfx::SE_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL,
-                                    Gfx::SE_ATTACHMENT_LOAD_OP_CLEAR, Gfx::SE_ATTACHMENT_STORE_OP_STORE);
+                                    Gfx::SE_ATTACHMENT_LOAD_OP_DONT_CARE, Gfx::SE_ATTACHMENT_STORE_OP_STORE);
+
+    msDepthAttachment =
+        Gfx::RenderTargetAttachment(msBasePassDepth, Gfx::SE_IMAGE_LAYOUT_UNDEFINED, Gfx::SE_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL,
+                                    Gfx::SE_ATTACHMENT_LOAD_OP_CLEAR, Gfx::SE_ATTACHMENT_STORE_OP_DONT_CARE);
+
+    colorAttachment = Gfx::RenderTargetAttachment(viewport, Gfx::SE_IMAGE_LAYOUT_UNDEFINED, Gfx::SE_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL,
+                                                  Gfx::SE_ATTACHMENT_LOAD_OP_DONT_CARE, Gfx::SE_ATTACHMENT_STORE_OP_STORE);
+
+    msColorAttachment =
+        Gfx::RenderTargetAttachment(msBasePassColor, Gfx::SE_IMAGE_LAYOUT_UNDEFINED, Gfx::SE_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL,
+                                    Gfx::SE_ATTACHMENT_LOAD_OP_CLEAR, Gfx::SE_ATTACHMENT_STORE_OP_DONT_CARE);
+
+    resources->registerRenderPassOutput("BASEPASS_COLOR", colorAttachment);
     resources->registerRenderPassOutput("BASEPASS_DEPTH", depthAttachment);
 
     query = graphics->createPipelineStatisticsQuery("BasePassPipelineStatistics");
@@ -328,15 +430,19 @@ void BasePass::createRenderPass() {
     cullingBuffer = resources->requestBuffer("CULLINGBUFFER");
 
     Gfx::RenderTargetLayout layout = Gfx::RenderTargetLayout{
-        .colorAttachments = {colorAttachment},
-        .depthAttachment = depthAttachment,
+        .colorAttachments = {msColorAttachment},
+        .resolveAttachments = {colorAttachment},
+        .depthAttachment = msDepthAttachment,
+        .depthResolveAttachment = {depthAttachment},
     };
     Array<Gfx::SubPassDependency> dependency = {
         {
             .srcSubpass = ~0U,
             .dstSubpass = 0,
-            .srcStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT,
-            .dstStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT,
+            .srcStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT |
+                        Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT,
+            .dstStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT |
+                        Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT,
             .srcAccess = Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT |
                          Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT,
             .dstAccess = Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT |
@@ -345,8 +451,10 @@ void BasePass::createRenderPass() {
         {
             .srcSubpass = 0,
             .dstSubpass = ~0U,
-            .srcStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT,
-            .dstStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT,
+            .srcStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT |
+                        Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT,
+            .dstStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT |
+                        Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT,
             .srcAccess = Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT |
                          Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT,
             .dstAccess = Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT |
@@ -358,4 +466,151 @@ void BasePass::createRenderPass() {
     tLightIndexList = resources->requestBuffer("LIGHTCULLING_TLIGHTLIST");
     oLightGrid = resources->requestTexture("LIGHTCULLING_OLIGHTGRID");
     tLightGrid = resources->requestTexture("LIGHTCULLING_TLIGHTGRID");
+
+    // Debug rendering
+    {
+        debugPipelineLayout = graphics->createPipelineLayout("DebugPassLayout");
+        debugPipelineLayout->addDescriptorLayout(viewParamsLayout);
+
+        ShaderCreateInfo createInfo = {
+            .name = "DebugVertex",
+            .mainModule = "Debug",
+            .entryPoint = "vertexMain",
+            .rootSignature = debugPipelineLayout,
+        };
+        debugVertexShader = graphics->createVertexShader(createInfo);
+
+        createInfo.name = "DebugFragment";
+        createInfo.entryPoint = "fragmentMain";
+        debugFragmentShader = graphics->createFragmentShader(createInfo);
+        debugPipelineLayout->create();
+
+        VertexInputStateCreateInfo inputCreate = {
+            .bindings =
+                {
+                    VertexInputBinding{
+                        .binding = 0,
+                        .stride = sizeof(DebugVertex),
+                        .inputRate = Gfx::SE_VERTEX_INPUT_RATE_VERTEX,
+                    },
+                },
+            .attributes =
+                {
+                    VertexInputAttribute{
+                        .location = 0,
+                        .binding = 0,
+                        .format = Gfx::SE_FORMAT_R32G32B32_SFLOAT,
+                        .offset = 0,
+                    },
+                    VertexInputAttribute{
+                        .location = 1,
+                        .binding = 0,
+                        .format = Gfx::SE_FORMAT_R32G32B32_SFLOAT,
+                        .offset = sizeof(Vector),
+                    },
+                },
+        };
+        debugVertexInput = graphics->createVertexInput(inputCreate);
+        Gfx::LegacyPipelineCreateInfo gfxInfo = {
+            .topology = Gfx::SE_PRIMITIVE_TOPOLOGY_LINE_LIST,
+            .vertexInput = debugVertexInput,
+            .vertexShader = debugVertexShader,
+            .fragmentShader = debugFragmentShader,
+            .renderPass = renderPass,
+            .pipelineLayout = debugPipelineLayout,
+            .multisampleState =
+                {
+                    .samples = viewport->getSamples(),
+                },
+            .rasterizationState =
+                {
+                    .polygonMode = Gfx::SE_POLYGON_MODE_LINE,
+                    .lineWidth = 5.f,
+                },
+            .colorBlend =
+                {
+                    .attachmentCount = 1,
+                },
+        };
+        debugPipeline = graphics->createGraphicsPipeline(std::move(gfxInfo));
+    }
+
+    // Skybox
+    {
+        skyboxDataLayout = graphics->createDescriptorLayout("pSkyboxData");
+        skyboxDataLayout->addDescriptorBinding(Gfx::DescriptorBinding{
+            .binding = 0,
+            .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
+        });
+        skyboxDataLayout->create();
+        textureLayout = graphics->createDescriptorLayout("pSkyboxTextures");
+        textureLayout->addDescriptorBinding(Gfx::DescriptorBinding{
+            .binding = 0,
+            .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
+        });
+        textureLayout->addDescriptorBinding(Gfx::DescriptorBinding{
+            .binding = 1,
+            .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
+        });
+        textureLayout->addDescriptorBinding(Gfx::DescriptorBinding{
+            .binding = 2,
+            .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_SAMPLER,
+        });
+        textureLayout->create();
+
+        skyboxSampler = graphics->createSampler({});
+
+        skyboxData.transformMatrix = Matrix4(1);
+        skyboxData.fogColor = skybox.fogColor;
+        skyboxData.blendFactor = skybox.blendFactor;
+
+        skyboxBuffer = graphics->createUniformBuffer(UniformBufferCreateInfo{
+            .sourceData =
+                {
+                    .size = sizeof(SkyboxData),
+                    .data = (uint8*)&skyboxData,
+                },
+            .dynamic = true,
+        });
+
+        pipelineLayout = graphics->createPipelineLayout("SkyboxLayout");
+        pipelineLayout->addDescriptorLayout(viewParamsLayout);
+        pipelineLayout->addDescriptorLayout(skyboxDataLayout);
+        pipelineLayout->addDescriptorLayout(textureLayout);
+
+        ShaderCreateInfo createInfo = {
+            .name = "SkyboxVertex",
+            .mainModule = "Skybox",
+            .entryPoint = "vertexMain",
+            .rootSignature = pipelineLayout,
+        };
+        vertexShader = graphics->createVertexShader(createInfo);
+
+        createInfo.name = "SkyboxFragment";
+        createInfo.entryPoint = "fragmentMain";
+        fragmentShader = graphics->createFragmentShader(createInfo);
+
+        pipelineLayout->create();
+
+        Gfx::LegacyPipelineCreateInfo gfxInfo = {
+            .topology = Gfx::SE_PRIMITIVE_TOPOLOGY_TRIANGLE_LIST,
+            .vertexShader = vertexShader,
+            .fragmentShader = fragmentShader,
+            .renderPass = renderPass,
+            .pipelineLayout = pipelineLayout,
+            .multisampleState =
+                {
+                    .samples = viewport->getSamples(),
+                },
+            .rasterizationState =
+                {
+                    .polygonMode = Gfx::SE_POLYGON_MODE_FILL,
+                },
+            .colorBlend =
+                {
+                    .attachmentCount = 1,
+                },
+        };
+        pipeline = graphics->createGraphicsPipeline(std::move(gfxInfo));
+    }
 }

src/Engine/Graphics/RenderPass/BasePass.h

@@ -17,7 +17,9 @@ class BasePass : public RenderPass {
     virtual void createRenderPass() override;
 
   private:
+    Gfx::RenderTargetAttachment msColorAttachment;
     Gfx::RenderTargetAttachment colorAttachment;
+    Gfx::RenderTargetAttachment msDepthAttachment;
     Gfx::RenderTargetAttachment depthAttachment;
     Gfx::RenderTargetAttachment visibilityAttachment;
     Gfx::PShaderBuffer oLightIndexList;
@@ -29,7 +31,9 @@ class BasePass : public RenderPass {
     Gfx::PDescriptorSet transparentCulling;
 
     // use a different texture here so we can do multisampling
+    Gfx::OTexture2D msBasePassDepth;
     Gfx::OTexture2D basePassDepth;
+    Gfx::OTexture2D msBasePassColor;
 
     // used for transparency sorting
     Vector cameraPos;
@@ -43,6 +47,32 @@ class BasePass : public RenderPass {
     Gfx::PTimestampQuery timestamps;
 
     Gfx::PShaderBuffer cullingBuffer;
+
+    // Debug rendering
+    Gfx::OVertexInput debugVertexInput;
+    Gfx::OVertexBuffer debugVertices;
+    Gfx::OVertexShader debugVertexShader;
+    Gfx::OFragmentShader debugFragmentShader;
+    Gfx::PGraphicsPipeline debugPipeline;
+    Gfx::OPipelineLayout debugPipelineLayout;
+
+    // Skybox
+    Gfx::ODescriptorLayout skyboxDataLayout;
+    Gfx::PDescriptorSet skyboxDataSet;
+    Gfx::ODescriptorLayout textureLayout;
+    Gfx::PDescriptorSet textureSet;
+    Gfx::OVertexShader vertexShader;
+    Gfx::OFragmentShader fragmentShader;
+    Gfx::OPipelineLayout pipelineLayout;
+    Gfx::PGraphicsPipeline pipeline;
+    Gfx::OSampler skyboxSampler;
+    struct SkyboxData {
+        Matrix4 transformMatrix;
+        Vector fogColor;
+        float blendFactor;
+    } skyboxData;
+    Gfx::OUniformBuffer skyboxBuffer;
+    Component::Skybox skybox;
 };
 DEFINE_REF(BasePass)
 } // namespace Seele

src/Engine/Graphics/RenderPass/CMakeLists.txt

@@ -4,8 +4,6 @@ target_sources(Engine
         BasePass.cpp
         CachedDepthPass.h
         CachedDepthPass.cpp
-        DebugPass.h
-        DebugPass.cpp
         DepthCullingPass.h
         DepthCullingPass.cpp
         LightCullingPass.h
@@ -17,8 +15,6 @@ target_sources(Engine
         RenderGraphResources.cpp
         RenderPass.h
         RenderPass.cpp
-        SkyboxRenderPass.h
-        SkyboxRenderPass.cpp
         TextPass.h
         TextPass.cpp
         UIPass.h
@@ -31,14 +27,12 @@ target_sources(Engine
         FILES
             BasePass.h
             CachedDepthPass.h
-            DebugPass.h
             DepthCullingPass.h
             LightCullingPass.h
             RayTracingPass.h
             RenderGraph.h
             RenderGraphResources.h
             RenderPass.h
-            SkyboxRenderPass.h
             TextPass.h
             UIPass.h
             VisibilityPass.h)

src/Engine/Graphics/RenderPass/CachedDepthPass.cpp

@@ -3,9 +3,6 @@
 
 using namespace Seele;
 
-extern bool usePositionOnly;
-extern bool useDepthCulling;
-
 CachedDepthPass::CachedDepthPass(Gfx::PGraphics graphics, PScene scene) : RenderPass(graphics, scene) {
     depthPrepassLayout = graphics->createPipelineLayout("CachedDepthLayout");
     depthPrepassLayout->addDescriptorLayout(viewParamsLayout);
@@ -43,7 +40,9 @@ CachedDepthPass::CachedDepthPass(Gfx::PGraphics graphics, PScene scene) : Render
 
 CachedDepthPass::~CachedDepthPass() {}
 
-void CachedDepthPass::beginFrame(const Component::Camera& cam) { RenderPass::beginFrame(cam); }
+void CachedDepthPass::beginFrame(const Component::Camera& cam) {
+    RenderPass::beginFrame(cam);
+}
 
 void CachedDepthPass::render() {
     query->beginQuery();
@@ -53,8 +52,8 @@ void CachedDepthPass::render() {
     Array<Gfx::ORenderCommand> commands;
 
     Gfx::ShaderPermutation permutation = graphics->getShaderCompiler()->getTemplate("CachedDepthPass");
-    permutation.setPositionOnly(usePositionOnly);
-    permutation.setDepthCulling(useDepthCulling);
+    permutation.setPositionOnly(getGlobals().usePositionOnly);
+    permutation.setDepthCulling(getGlobals().useDepthCulling);
     for (VertexData* vertexData : VertexData::getList()) {
         permutation.setVertexData(vertexData->getTypeName());
         vertexData->getInstanceDataSet()->updateBuffer(6, cullingBuffer);
@@ -79,10 +78,6 @@ void CachedDepthPass::render() {
                 .fragmentShader = collection->fragmentShader,
                 .renderPass = renderPass,
                 .pipelineLayout = collection->pipelineLayout,
-                .multisampleState =
-                    {
-                        .samples = viewport->getSamples(),
-                    },
                 .colorBlend =
                     {
                         .attachmentCount = 1,
@@ -96,10 +91,6 @@ void CachedDepthPass::render() {
                 .fragmentShader = collection->fragmentShader,
                 .renderPass = renderPass,
                 .pipelineLayout = collection->pipelineLayout,
-                .multisampleState =
-                    {
-                        .samples = viewport->getSamples(),
-                    },
                 .colorBlend =
                     {
                         .attachmentCount = 1,

src/Engine/Graphics/RenderPass/DebugPass.cpp

@@ -1,156 +0,0 @@
-#include "DebugPass.h"
-#include "Graphics/Graphics.h"
-#include "Graphics/Pipeline.h"
-#include "Graphics/RenderTarget.h"
-#include "Graphics/Shader.h"
-
-
-using namespace Seele;
-
-Array<DebugVertex> gDebugVertices;
-
-void Seele::addDebugVertex(DebugVertex vert) { gDebugVertices.add(vert); }
-
-void Seele::addDebugVertices(Array<DebugVertex> verts) { gDebugVertices.addAll(verts); }
-
-DebugPass::DebugPass(Gfx::PGraphics graphics, PScene scene) : RenderPass(graphics, scene) {}
-
-DebugPass::~DebugPass() {}
-
-void DebugPass::beginFrame(const Component::Camera& cam) {
-    RenderPass::beginFrame(cam);
-
-    VertexBufferCreateInfo vertexBufferInfo = {
-        .sourceData =
-            {
-                .size = sizeof(DebugVertex) * gDebugVertices.size(),
-                .data = (uint8*)gDebugVertices.data(),
-            },
-        .vertexSize = sizeof(DebugVertex),
-        .numVertices = (uint32)gDebugVertices.size(),
-        .name = "DebugVertices",
-    };
-    debugVertices = graphics->createVertexBuffer(vertexBufferInfo);
-}
-
-void DebugPass::render() {
-    graphics->beginRenderPass(renderPass);
-    if (gDebugVertices.size() > 0) {
-        Gfx::ORenderCommand renderCommand = graphics->createRenderCommand("DebugRender");
-        renderCommand->setViewport(viewport);
-        renderCommand->bindPipeline(pipeline);
-        renderCommand->bindDescriptor(viewParamsSet);
-        renderCommand->bindVertexBuffer({debugVertices});
-        renderCommand->draw((uint32)gDebugVertices.size(), 1, 0, 0);
-        Array<Gfx::ORenderCommand> commands;
-        commands.add(std::move(renderCommand));
-        graphics->executeCommands({std::move(commands)});
-    }
-    graphics->endRenderPass();
-    gDebugVertices.clear();
-    // Sync color write with next pass/swapchain present
-    // colorAttachment.getTexture()->pipelineBarrier(
-    //    Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT,
-    //    Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT,
-    //    Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT,
-    //    Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT
-    //);
-    // Sync depth with next pass/next frame
-    // depthAttachment.getTexture()->pipelineBarrier(
-    //    Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT,
-    //    Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT,
-    //    Gfx::SE_ACCESS_MEMORY_WRITE_BIT,
-    //    Gfx::SE_PIPELINE_STAGE_TOP_OF_PIPE_BIT
-    //);
-}
-
-void DebugPass::endFrame() {}
-
-void DebugPass::publishOutputs() {}
-
-void DebugPass::createRenderPass() {
-    colorAttachment = resources->requestRenderTarget("BASEPASS_COLOR");
-    colorAttachment.setLoadOp(Gfx::SE_ATTACHMENT_LOAD_OP_LOAD);
-    colorAttachment.setInitialLayout(Gfx::SE_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL);
-    colorAttachment.setInitialLayout(Gfx::SE_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL);
-
-    depthAttachment = resources->requestRenderTarget("BASEPASS_DEPTH");
-    depthAttachment.setLoadOp(Gfx::SE_ATTACHMENT_LOAD_OP_LOAD);
-    depthAttachment.setInitialLayout(Gfx::SE_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL);
-    depthAttachment.setFinalLayout(Gfx::SE_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL);
-    Gfx::RenderTargetLayout layout = Gfx::RenderTargetLayout{
-        .colorAttachments = {colorAttachment},
-        .depthAttachment = depthAttachment,
-    };
-
-    Array<Gfx::SubPassDependency> dependency = {
-        {
-            .srcSubpass = ~0U,
-            .dstSubpass = 0,
-            .srcStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT,
-            .dstStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT,
-            .srcAccess = Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT |
-                         Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT,
-            .dstAccess = Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT |
-                         Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT,
-        },
-        {
-            .srcSubpass = 0,
-            .dstSubpass = ~0U,
-            .srcStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT,
-            .dstStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT,
-            .srcAccess = Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT |
-                         Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT,
-            .dstAccess = Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT |
-                         Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT,
-        },
-    };
-    renderPass = graphics->createRenderPass(std::move(layout), dependency, viewport);
-
-    pipelineLayout = graphics->createPipelineLayout("DebugPassLayout");
-    pipelineLayout->addDescriptorLayout(viewParamsLayout);
-
-    ShaderCreateInfo createInfo = {
-        .name = "DebugVertex",
-        .mainModule = "Debug",
-        .entryPoint = "vertexMain",
-        .rootSignature = pipelineLayout,
-    };
-    vertexShader = graphics->createVertexShader(createInfo);
-
-    createInfo.name = "DebugFragment";
-    createInfo.entryPoint = "fragmentMain";
-    fragmentShader = graphics->createFragmentShader(createInfo);
-    pipelineLayout->create();
-
-    VertexInputStateCreateInfo inputCreate = {
-        .bindings =
-            {
-                VertexInputBinding{
-                    .binding = 0,
-                    .stride = sizeof(DebugVertex),
-                    .inputRate = Gfx::SE_VERTEX_INPUT_RATE_VERTEX,
-                },
-            },
-        .attributes = {VertexInputAttribute{
-                           .location = 0,
-                           .binding = 0,
-                           .format = Gfx::SE_FORMAT_R32G32B32_SFLOAT,
-                           .offset = 0,
-                       },
-                       VertexInputAttribute{
-                           .location = 1, .binding = 0, .format = Gfx::SE_FORMAT_R32G32B32_SFLOAT, .offset = sizeof(Vector)}},
-    };
-    vertexInput = graphics->createVertexInput(inputCreate);
-    Gfx::LegacyPipelineCreateInfo gfxInfo;
-    gfxInfo.vertexInput = vertexInput;
-    gfxInfo.vertexShader = vertexShader;
-    gfxInfo.fragmentShader = fragmentShader;
-    gfxInfo.rasterizationState.polygonMode = Gfx::SE_POLYGON_MODE_LINE;
-    gfxInfo.topology = Gfx::SE_PRIMITIVE_TOPOLOGY_LINE_LIST;
-    gfxInfo.pipelineLayout = std::move(pipelineLayout);
-    gfxInfo.renderPass = renderPass;
-    gfxInfo.colorBlend.attachmentCount = 1;
-    gfxInfo.rasterizationState.lineWidth = 5.f;
-    pipeline = graphics->createGraphicsPipeline(std::move(gfxInfo));
-}

src/Engine/Graphics/RenderPass/DebugPass.h

@@ -1,35 +0,0 @@
-#pragma once
-#include "Graphics/DebugVertex.h"
-#include "Graphics/Pipeline.h"
-#include "RenderPass.h"
-#include "Scene/Scene.h"
-
-
-namespace Seele {
-DECLARE_REF(CameraActor)
-DECLARE_REF(Scene)
-DECLARE_REF(Viewport)
-class DebugPass : public RenderPass {
-  public:
-    DebugPass(Gfx::PGraphics graphics, PScene scene);
-    DebugPass(DebugPass&&) = default;
-    DebugPass& operator=(DebugPass&&) = default;
-    virtual ~DebugPass();
-    virtual void beginFrame(const Component::Camera& cam) override;
-    virtual void render() override;
-    virtual void endFrame() override;
-    virtual void publishOutputs() override;
-    virtual void createRenderPass() override;
-
-  private:
-    Gfx::RenderTargetAttachment colorAttachment;
-    Gfx::RenderTargetAttachment depthAttachment;
-    Gfx::OVertexInput vertexInput;
-    Gfx::OVertexBuffer debugVertices;
-    Gfx::OVertexShader vertexShader;
-    Gfx::OFragmentShader fragmentShader;
-    Gfx::PGraphicsPipeline pipeline;
-    Gfx::OPipelineLayout pipelineLayout;
-};
-DEFINE_REF(DebugPass)
-} // namespace Seele

src/Engine/Graphics/RenderPass/DepthCullingPass.cpp

@@ -4,9 +4,6 @@
 
 using namespace Seele;
 
-extern bool usePositionOnly;
-extern bool useDepthCulling;
-
 DepthCullingPass::DepthCullingPass(Gfx::PGraphics graphics, PScene scene) : RenderPass(graphics, scene) {
     depthAttachmentLayout = graphics->createDescriptorLayout("pDepthAttachment");
     depthAttachmentLayout->addDescriptorBinding(Gfx::DescriptorBinding{
@@ -68,13 +65,15 @@ DepthCullingPass::DepthCullingPass(Gfx::PGraphics graphics, PScene scene) : Rend
 
 DepthCullingPass::~DepthCullingPass() {}
 
-void DepthCullingPass::beginFrame(const Component::Camera& cam) { RenderPass::beginFrame(cam); }
+void DepthCullingPass::beginFrame(const Component::Camera& cam) {
+    RenderPass::beginFrame(cam);
+}
 
 void DepthCullingPass::render() {
     query->beginQuery();
     depthAttachment.getTexture()->changeLayout(Gfx::SE_IMAGE_LAYOUT_GENERAL, Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT,
-                                               Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT, Gfx::SE_ACCESS_TRANSFER_READ_BIT,
-                                               Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT);
+                                               Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT, Gfx::SE_ACCESS_SHADER_READ_BIT,
+                                               Gfx::SE_PIPELINE_STAGE_COMPUTE_SHADER_BIT);
 
     Gfx::PDescriptorSet set = depthAttachmentLayout->allocateDescriptorSet();
     set->updateTexture(0, Gfx::PTexture2D(depthAttachment.getTexture()));
@@ -123,8 +122,8 @@ void DepthCullingPass::render() {
     Array<Gfx::ORenderCommand> commands;
 
     Gfx::ShaderPermutation permutation = graphics->getShaderCompiler()->getTemplate("DepthPass");
-    permutation.setPositionOnly(usePositionOnly);
-    permutation.setDepthCulling(useDepthCulling);
+    permutation.setPositionOnly(getGlobals().usePositionOnly);
+    permutation.setDepthCulling(getGlobals().useDepthCulling);
     for (VertexData* vertexData : VertexData::getList()) {
         permutation.setVertexData(vertexData->getTypeName());
         vertexData->getInstanceDataSet()->updateBuffer(6, cullingBuffer);
@@ -148,10 +147,6 @@ void DepthCullingPass::render() {
                 .fragmentShader = collection->fragmentShader,
                 .renderPass = renderPass,
                 .pipelineLayout = collection->pipelineLayout,
-                .multisampleState =
-                    {
-                        .samples = viewport->getSamples(),
-                    },
                 .colorBlend =
                     {
                         .attachmentCount = 1,
@@ -165,10 +160,6 @@ void DepthCullingPass::render() {
                 .fragmentShader = collection->fragmentShader,
                 .renderPass = renderPass,
                 .pipelineLayout = collection->pipelineLayout,
-                .multisampleState =
-                    {
-                        .samples = viewport->getSamples(),
-                    },
                 .colorBlend =
                     {
                         .attachmentCount = 1,

src/Engine/Graphics/RenderPass/LightCullingPass.cpp

@@ -8,8 +8,6 @@
 
 using namespace Seele;
 
-extern bool useLightCulling;
-
 LightCullingPass::LightCullingPass(Gfx::PGraphics graphics, PScene scene) : RenderPass(graphics, scene) {}
 
 LightCullingPass::~LightCullingPass() {}
@@ -25,7 +23,13 @@ void LightCullingPass::beginFrame(const Component::Camera& cam) {
                                         Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT);
     uint32 reset = 0;
     ShaderBufferCreateInfo counterReset = {
-        .sourceData = {.size = sizeof(uint32), .data = (uint8*)&reset, .owner = Gfx::QueueType::COMPUTE}};
+        .sourceData =
+            {
+                .size = sizeof(uint32),
+                .data = (uint8*)&reset,
+                .owner = Gfx::QueueType::COMPUTE,
+            },
+    };
     oLightIndexCounter->rotateBuffer(sizeof(uint32));
     oLightIndexCounter->updateContents(counterReset);
     tLightIndexCounter->rotateBuffer(sizeof(uint32));
@@ -42,7 +46,10 @@ void LightCullingPass::beginFrame(const Component::Camera& cam) {
 void LightCullingPass::render() {
     query->beginQuery();
     timestamps->write(Gfx::SE_PIPELINE_STAGE_TOP_OF_PIPE_BIT, "LIGHTCULL");
-    depthAttachment->transferOwnership(Gfx::QueueType::COMPUTE);
+    oLightGrid->pipelineBarrier(Gfx::SE_ACCESS_SHADER_READ_BIT, Gfx::SE_PIPELINE_STAGE_FRAGMENT_SHADER_BIT, Gfx::SE_ACCESS_SHADER_WRITE_BIT,
+                                Gfx::SE_PIPELINE_STAGE_COMPUTE_SHADER_BIT);
+    tLightGrid->pipelineBarrier(Gfx::SE_ACCESS_SHADER_READ_BIT, Gfx::SE_PIPELINE_STAGE_FRAGMENT_SHADER_BIT, Gfx::SE_ACCESS_SHADER_WRITE_BIT,
+                                Gfx::SE_PIPELINE_STAGE_COMPUTE_SHADER_BIT);
     cullingDescriptorSet->updateTexture(0, depthAttachment);
     cullingDescriptorSet->updateBuffer(1, oLightIndexCounter);
     cullingDescriptorSet->updateBuffer(2, tLightIndexCounter);
@@ -52,7 +59,7 @@ void LightCullingPass::render() {
     cullingDescriptorSet->updateTexture(6, Gfx::PTexture2D(tLightGrid));
     cullingDescriptorSet->writeChanges();
     Gfx::OComputeCommand computeCommand = graphics->createComputeCommand("CullingCommand");
-    if (useLightCulling) {
+    if (getGlobals().useLightCulling) {
         computeCommand->bindPipeline(cullingEnabledPipeline);
     } else {
         computeCommand->bindPipeline(cullingPipeline);
@@ -84,11 +91,17 @@ void LightCullingPass::publishOutputs() {
     dispatchParams.numThreadGroups = numThreadGroups;
     dispatchParams.numThreads = numThreadGroups * glm::uvec3(BLOCK_SIZE, BLOCK_SIZE, 1);
     dispatchParamsBuffer = graphics->createUniformBuffer(UniformBufferCreateInfo{
-        .sourceData = {.size = sizeof(DispatchParams), .data = (uint8*)&dispatchParams, .owner = Gfx::QueueType::COMPUTE},
+        .sourceData =
+            {
+                .size = sizeof(DispatchParams),
+                .data = (uint8*)&dispatchParams,
+                .owner = Gfx::QueueType::COMPUTE,
+            },
         .dynamic = false,
         .name = "DispatchParams",
     });
-
+    dispatchParamsBuffer->pipelineBarrier(Gfx::SE_ACCESS_TRANSFER_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT,
+                                          Gfx::SE_ACCESS_UNIFORM_READ_BIT, Gfx::SE_PIPELINE_STAGE_COMPUTE_SHADER_BIT);
     dispatchParamsSet = dispatchParamsLayout->allocateDescriptorSet();
     dispatchParamsSet->updateBuffer(0, dispatchParamsBuffer);
     dispatchParamsSet->updateBuffer(1, frustumBuffer);
@@ -209,6 +222,10 @@ void LightCullingPass::publishOutputs() {
     };
     oLightGrid = graphics->createTexture2D(textureInfo);
     tLightGrid = graphics->createTexture2D(textureInfo);
+    oLightGrid->changeLayout(Gfx::SE_IMAGE_LAYOUT_GENERAL, Gfx::SE_ACCESS_NONE, Gfx::SE_PIPELINE_STAGE_TOP_OF_PIPE_BIT,
+                             Gfx::SE_ACCESS_SHADER_READ_BIT | Gfx::SE_ACCESS_SHADER_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_COMPUTE_SHADER_BIT);
+    tLightGrid->changeLayout(Gfx::SE_IMAGE_LAYOUT_GENERAL, Gfx::SE_ACCESS_NONE, Gfx::SE_PIPELINE_STAGE_TOP_OF_PIPE_BIT,
+                             Gfx::SE_ACCESS_SHADER_READ_BIT | Gfx::SE_ACCESS_SHADER_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_COMPUTE_SHADER_BIT);
 
     resources->registerTextureOutput("LIGHTCULLING_OLIGHTGRID", Gfx::PTexture2D(oLightGrid));
     resources->registerTextureOutput("LIGHTCULLING_TLIGHTGRID", Gfx::PTexture2D(tLightGrid));
@@ -230,6 +247,8 @@ void LightCullingPass::setupFrustums() {
     glm::uvec3 numThreadGroups = glm::ceil(glm::vec3(numThreads.x / (float)BLOCK_SIZE, numThreads.y / (float)BLOCK_SIZE, 1));
 
     RenderPass::beginFrame(Component::Camera());
+    viewParamsBuffer->pipelineBarrier(Gfx::SE_ACCESS_TRANSFER_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT,
+                                      Gfx::SE_ACCESS_UNIFORM_READ_BIT, Gfx::SE_PIPELINE_STAGE_COMPUTE_SHADER_BIT);
     dispatchParams.numThreads = numThreads;
     dispatchParams.numThreadGroups = numThreadGroups;
 

src/Engine/Graphics/RenderPass/LightCullingPass.h

@@ -41,7 +41,6 @@ class LightCullingPass : public RenderPass {
 
     Gfx::OShaderBuffer frustumBuffer;
     Gfx::OUniformBuffer dispatchParamsBuffer;
-    Gfx::OUniformBuffer viewParamsBuffer;
     Gfx::ODescriptorLayout dispatchParamsLayout;
     Gfx::PDescriptorSet dispatchParamsSet;
     Gfx::OComputeShader frustumShader;

src/Engine/Graphics/RenderPass/RenderPass.cpp

@@ -40,7 +40,9 @@ void RenderPass::beginFrame(const Component::Camera& cam) {
     viewParamsBuffer->rotateBuffer(sizeof(ViewParameter));
     viewParamsBuffer->updateContents(uniformUpdate);
     viewParamsBuffer->pipelineBarrier(Gfx::SE_ACCESS_TRANSFER_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT,
-                                      Gfx::SE_ACCESS_MEMORY_READ_BIT, Gfx::SE_PIPELINE_STAGE_ALL_COMMANDS_BIT);
+                                      Gfx::SE_ACCESS_UNIFORM_READ_BIT,
+                                      Gfx::SE_PIPELINE_STAGE_TASK_SHADER_BIT_EXT | Gfx::SE_PIPELINE_STAGE_MESH_SHADER_BIT_EXT |
+                                          Gfx::SE_PIPELINE_STAGE_VERTEX_SHADER_BIT | Gfx::SE_PIPELINE_STAGE_COMPUTE_SHADER_BIT);
     viewParamsLayout->reset();
     viewParamsSet = viewParamsLayout->allocateDescriptorSet();
     viewParamsSet->updateBuffer(0, viewParamsBuffer);

src/Engine/Graphics/RenderPass/SkyboxRenderPass.cpp

@@ -1,176 +0,0 @@
-#include "SkyboxRenderPass.h"
-#include "Asset/AssetRegistry.h"
-#include "Graphics/Command.h"
-#include "Graphics/Graphics.h"
-
-using namespace Seele;
-
-SkyboxRenderPass::SkyboxRenderPass(Gfx::PGraphics graphics, PScene scene) : RenderPass(graphics, scene) {
-    skybox = Seele::Component::Skybox{
-        .day = AssetRegistry::findTexture("", "skyboxsun5deg_tn")->getTexture().cast<Gfx::TextureCube>(),
-        .night = AssetRegistry::findTexture("", "skyboxsun5deg_tn")->getTexture().cast<Gfx::TextureCube>(),
-        .fogColor = Vector(0.1, 0.1, 0.8),
-        .blendFactor = 0,
-    };
-}
-SkyboxRenderPass::~SkyboxRenderPass() {}
-
-void SkyboxRenderPass::beginFrame(const Component::Camera& cam) {
-    RenderPass::beginFrame(cam);
-
-    skyboxDataLayout->reset();
-    textureLayout->reset();
-    skyboxData.transformMatrix = glm::rotate(skyboxData.transformMatrix, (float)(Gfx::getCurrentFrameDelta()), Vector(0, 1, 0));
-    skyboxBuffer->updateContents(DataSource{
-        .size = sizeof(SkyboxData),
-        .data = (uint8*)&skyboxData,
-    });
-    skyboxDataSet = skyboxDataLayout->allocateDescriptorSet();
-    skyboxDataSet->updateBuffer(0, skyboxBuffer);
-    skyboxDataSet->writeChanges();
-    skyboxBuffer->pipelineBarrier(Gfx::SE_ACCESS_TRANSFER_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT, Gfx::SE_ACCESS_MEMORY_READ_BIT,
-                                  Gfx::SE_PIPELINE_STAGE_VERTEX_SHADER_BIT);
-    textureSet = textureLayout->allocateDescriptorSet();
-    textureSet->updateTexture(0, skybox.day);
-    textureSet->updateTexture(1, skybox.night);
-    textureSet->updateSampler(2, skyboxSampler);
-    textureSet->writeChanges();
-}
-
-void SkyboxRenderPass::render() {
-    colorAttachment.getTexture()->pipelineBarrier(
-        Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT,
-        Gfx::SE_ACCESS_COLOR_ATTACHMENT_READ_BIT, Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT);
-    depthAttachment.getTexture()->pipelineBarrier(
-        Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT,
-        Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, Gfx::SE_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT);
-    graphics->beginRenderPass(renderPass);
-    Gfx::ORenderCommand renderCommand = graphics->createRenderCommand("SkyboxRender");
-    renderCommand->setViewport(viewport);
-    renderCommand->bindPipeline(pipeline);
-    renderCommand->bindDescriptor({viewParamsSet, skyboxDataSet, textureSet});
-    renderCommand->draw(36, 1, 0, 0);
-    Array<Gfx::ORenderCommand> commands;
-    commands.add(std::move(renderCommand));
-    graphics->executeCommands(std::move(commands));
-    graphics->endRenderPass();
-}
-
-void SkyboxRenderPass::endFrame() {}
-
-void SkyboxRenderPass::publishOutputs() {
-    skyboxDataLayout = graphics->createDescriptorLayout("pSkyboxData");
-    skyboxDataLayout->addDescriptorBinding(Gfx::DescriptorBinding{
-        .binding = 0,
-        .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
-    });
-    skyboxDataLayout->create();
-    textureLayout = graphics->createDescriptorLayout("pSkyboxTextures");
-    textureLayout->addDescriptorBinding(Gfx::DescriptorBinding{
-        .binding = 0,
-        .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
-    });
-    textureLayout->addDescriptorBinding(Gfx::DescriptorBinding{
-        .binding = 1,
-        .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
-    });
-    textureLayout->addDescriptorBinding(Gfx::DescriptorBinding{
-        .binding = 2,
-        .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_SAMPLER,
-    });
-    textureLayout->create();
-
-    skyboxSampler = graphics->createSampler({});
-}
-
-void SkyboxRenderPass::createRenderPass() {
-    colorAttachment = resources->requestRenderTarget("BASEPASS_COLOR");
-    colorAttachment.setLoadOp(Gfx::SE_ATTACHMENT_LOAD_OP_LOAD);
-    colorAttachment.setInitialLayout(Gfx::SE_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL);
-    colorAttachment.setInitialLayout(Gfx::SE_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL);
-
-    depthAttachment = resources->requestRenderTarget("BASEPASS_DEPTH");
-    depthAttachment.setLoadOp(Gfx::SE_ATTACHMENT_LOAD_OP_LOAD);
-    depthAttachment.setInitialLayout(Gfx::SE_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL);
-    depthAttachment.setFinalLayout(Gfx::SE_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL);
-    Gfx::RenderTargetLayout layout = Gfx::RenderTargetLayout{
-        .colorAttachments = {colorAttachment},
-        .depthAttachment = depthAttachment,
-    };
-    Array<Gfx::SubPassDependency> dependency = {
-        {
-            .srcSubpass = ~0U,
-            .dstSubpass = 0,
-            .srcStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT,
-            .dstStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT,
-            .srcAccess = Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT |
-                         Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT,
-            .dstAccess = Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT |
-                         Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT,
-        },
-        {
-            .srcSubpass = 0,
-            .dstSubpass = ~0U,
-            .srcStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT,
-            .dstStage = Gfx::SE_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | Gfx::SE_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT,
-            .srcAccess = Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT |
-                         Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT,
-            .dstAccess = Gfx::SE_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT |
-                         Gfx::SE_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT,
-        },
-    };
-    renderPass = graphics->createRenderPass(std::move(layout), dependency, viewport);
-
-    skyboxData.transformMatrix = Matrix4(1);
-    skyboxData.fogColor = skybox.fogColor;
-    skyboxData.blendFactor = skybox.blendFactor;
-
-    skyboxBuffer = graphics->createUniformBuffer(UniformBufferCreateInfo{
-        .sourceData =
-            {
-                .size = sizeof(SkyboxData),
-                .data = (uint8*)&skyboxData,
-            },
-        .dynamic = true,
-    });
-
-    pipelineLayout = graphics->createPipelineLayout("SkyboxLayout");
-    pipelineLayout->addDescriptorLayout(viewParamsLayout);
-    pipelineLayout->addDescriptorLayout(skyboxDataLayout);
-    pipelineLayout->addDescriptorLayout(textureLayout);
-
-    ShaderCreateInfo createInfo = {
-        .name = "SkyboxVertex",
-        .mainModule = "Skybox",
-        .entryPoint = "vertexMain",
-        .rootSignature = pipelineLayout,
-    };
-    vertexShader = graphics->createVertexShader(createInfo);
-
-    createInfo.name = "SkyboxFragment";
-    createInfo.entryPoint = "fragmentMain";
-    fragmentShader = graphics->createFragmentShader(createInfo);
-
-    pipelineLayout->create();
-
-    Gfx::LegacyPipelineCreateInfo gfxInfo = {
-        .topology = Gfx::SE_PRIMITIVE_TOPOLOGY_TRIANGLE_LIST,
-        .vertexShader = vertexShader,
-        .fragmentShader = fragmentShader,
-        .renderPass = renderPass,
-        .pipelineLayout = pipelineLayout,
-        .multisampleState =
-            {
-                .samples = viewport->getSamples(),
-            },
-        .rasterizationState =
-            {
-                .polygonMode = Gfx::SE_POLYGON_MODE_FILL,
-            },
-        .colorBlend =
-            {
-                .attachmentCount = 1,
-            },
-    };
-    pipeline = graphics->createGraphicsPipeline(std::move(gfxInfo));
-}

src/Engine/Graphics/RenderPass/SkyboxRenderPass.h

@@ -1,41 +0,0 @@
-#pragma once
-#include "Component/Skybox.h"
-#include "Graphics/Shader.h"
-#include "RenderPass.h"
-
-
-namespace Seele {
-class SkyboxRenderPass : public RenderPass {
-  public:
-    SkyboxRenderPass(Gfx::PGraphics graphics, PScene scene);
-    SkyboxRenderPass(SkyboxRenderPass&&) = default;
-    SkyboxRenderPass& operator=(SkyboxRenderPass&&) = default;
-    virtual ~SkyboxRenderPass();
-    virtual void beginFrame(const Component::Camera& cam) override;
-    virtual void render() override;
-    virtual void endFrame() override;
-    virtual void publishOutputs() override;
-    virtual void createRenderPass() override;
-
-  private:
-    Gfx::RenderTargetAttachment colorAttachment;
-    Gfx::RenderTargetAttachment depthAttachment;
-    Gfx::ODescriptorLayout skyboxDataLayout;
-    Gfx::PDescriptorSet skyboxDataSet;
-    Gfx::ODescriptorLayout textureLayout;
-    Gfx::PDescriptorSet textureSet;
-    Gfx::OVertexShader vertexShader;
-    Gfx::OFragmentShader fragmentShader;
-    Gfx::OPipelineLayout pipelineLayout;
-    Gfx::PGraphicsPipeline pipeline;
-    Gfx::OSampler skyboxSampler;
-    struct SkyboxData {
-        Matrix4 transformMatrix;
-        Vector fogColor;
-        float blendFactor;
-    } skyboxData;
-    Gfx::OUniformBuffer skyboxBuffer;
-    Component::Skybox skybox;
-};
-DEFINE_REF(SkyboxRenderPass)
-} // namespace Seele

src/Engine/Graphics/RenderPass/VisibilityPass.cpp

@@ -3,8 +3,6 @@
 
 using namespace Seele;
 
-extern bool resetVisibility;
-
 VisibilityPass::VisibilityPass(Gfx::PGraphics graphics, PScene scene) : RenderPass(graphics, scene) {}
 
 VisibilityPass::~VisibilityPass() {}

src/Engine/Graphics/Resources.h

@@ -3,11 +3,6 @@
 #include "Enums.h"
 #include "Math/Math.h"
 
-
-#ifndef ENABLE_VALIDATION
-#define ENABLE_VALIDATION 1
-#endif
-
 namespace Seele {
 DECLARE_REF(Material)
 namespace Gfx {

src/Engine/Graphics/VertexData.cpp

@@ -211,198 +211,195 @@ void VertexData::createDescriptors() {
 }
 
 void VertexData::loadMesh(MeshId id, Array<uint32> loadedIndices, Array<Meshlet> loadedMeshlets) {
-        std::unique_lock l(vertexDataLock);
-        meshlets.reserve(meshlets.size() + loadedMeshlets.size());
-        vertexIndices.reserve(vertexIndices.size() + loadedMeshlets.size() * Gfx::numVerticesPerMeshlet);
-        primitiveIndices.reserve(primitiveIndices.size() + loadedMeshlets.size() * Gfx::numPrimitivesPerMeshlet * 3);
-        uint32 meshletOffset = meshlets.size();
-        AABB meshAABB;
-        for (uint32 i = 0; i < loadedMeshlets.size(); ++i) {
-            Meshlet& m = loadedMeshlets[i];
-            meshAABB = meshAABB.combine(m.boundingBox);
-            uint32 vertexOffset = vertexIndices.size();
-            vertexIndices.resize(vertexOffset + m.numVertices);
-            std::memcpy(vertexIndices.data() + vertexOffset, m.uniqueVertices, m.numVertices * sizeof(uint32));
-            uint32 primitiveOffset = primitiveIndices.size();
-            primitiveIndices.resize(primitiveOffset + (m.numPrimitives * 3));
-            std::memcpy(primitiveIndices.data() + primitiveOffset, m.primitiveLayout, m.numPrimitives * 3 * sizeof(uint8));
-            meshlets.add(MeshletDescription{
-                .bounding = m.boundingBox, //.toSphere(),
-                .vertexCount = m.numVertices,
-                .primitiveCount = m.numPrimitives,
-                .vertexOffset = vertexOffset,
-                .primitiveOffset = primitiveOffset,
-                .color = Vector((float)rand() / RAND_MAX, (float)rand() / RAND_MAX, (float)rand() / RAND_MAX),
-                .indicesOffset = (uint32)meshOffsets[id],
-            });
-        }
-        meshData[id] = MeshData{
-            .bounding = meshAABB, //.toSphere(),
-            .numMeshlets = (uint32)loadedMeshlets.size(),
-            .meshletOffset = meshletOffset,
-            .firstIndex = (uint32)indices.size(),
-            .numIndices = (uint32)loadedIndices.size(),
-        };
+    std::unique_lock l(vertexDataLock);
+    meshlets.reserve(meshlets.size() + loadedMeshlets.size());
+    vertexIndices.reserve(vertexIndices.size() + loadedMeshlets.size() * Gfx::numVerticesPerMeshlet);
+    primitiveIndices.reserve(primitiveIndices.size() + loadedMeshlets.size() * Gfx::numPrimitivesPerMeshlet * 3);
+    uint32 meshletOffset = meshlets.size();
+    AABB meshAABB;
+    for (uint32 i = 0; i < loadedMeshlets.size(); ++i) {
+        Meshlet& m = loadedMeshlets[i];
+        meshAABB = meshAABB.combine(m.boundingBox);
+        uint32 vertexOffset = vertexIndices.size();
+        vertexIndices.resize(vertexOffset + m.numVertices);
+        std::memcpy(vertexIndices.data() + vertexOffset, m.uniqueVertices, m.numVertices * sizeof(uint32));
+        uint32 primitiveOffset = primitiveIndices.size();
+        primitiveIndices.resize(primitiveOffset + (m.numPrimitives * 3));
+        std::memcpy(primitiveIndices.data() + primitiveOffset, m.primitiveLayout, m.numPrimitives * 3 * sizeof(uint8));
+        meshlets.add(MeshletDescription{
+            .bounding = m.boundingBox, //.toSphere(),
+            .vertexCount = m.numVertices,
+            .primitiveCount = m.numPrimitives,
+            .vertexOffset = vertexOffset,
+            .primitiveOffset = primitiveOffset,
+            .color = Vector((float)rand() / RAND_MAX, (float)rand() / RAND_MAX, (float)rand() / RAND_MAX),
+            .indicesOffset = (uint32)meshOffsets[id],
+        });
+    }
+    meshData[id] = MeshData{
+        .bounding = meshAABB, //.toSphere(),
+        .numMeshlets = (uint32)loadedMeshlets.size(),
+        .meshletOffset = meshletOffset,
+        .firstIndex = (uint32)indices.size(),
+        .numIndices = (uint32)loadedIndices.size(),
+    };
 
-        indices.resize(indices.size() + loadedIndices.size());
-        std::memcpy(indices.data() + meshData[id].firstIndex, loadedIndices.data(), loadedIndices.size() * sizeof(uint32));
+    indices.resize(indices.size() + loadedIndices.size());
+    std::memcpy(indices.data() + meshData[id].firstIndex, loadedIndices.data(), loadedIndices.size() * sizeof(uint32));
 }
 
 void VertexData::commitMeshes() {
-        indexBuffer = graphics->createIndexBuffer(IndexBufferCreateInfo{
-            .sourceData =
-                {
-                    .size = sizeof(uint32) * indices.size(),
-                    .data = (uint8*)indices.data(),
-                },
-            .indexType = Gfx::SE_INDEX_TYPE_UINT32,
-            .name = "IndexBuffer",
-        });
-        meshletBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
-            .sourceData =
-                {
-                    .size = sizeof(MeshletDescription) * meshlets.size(),
-                    .data = (uint8*)meshlets.data(),
-                },
-            .numElements = meshlets.size(),
-            .dynamic = false,
-            .name = "MeshletBuffer",
-        });
-        vertexIndicesBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
-            .sourceData =
-                {
-                    .size = sizeof(uint32) * vertexIndices.size(),
-                    .data = (uint8*)vertexIndices.data(),
-                },
-            .numElements = vertexIndices.size(),
-            .dynamic = false,
-            .name = "VertexIndicesBuffer",
-        });
+    indexBuffer = graphics->createIndexBuffer(IndexBufferCreateInfo{
+        .sourceData =
+            {
+                .size = sizeof(uint32) * indices.size(),
+                .data = (uint8*)indices.data(),
+            },
+        .indexType = Gfx::SE_INDEX_TYPE_UINT32,
+        .name = "IndexBuffer",
+    });
+    meshletBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
+        .sourceData =
+            {
+                .size = sizeof(MeshletDescription) * meshlets.size(),
+                .data = (uint8*)meshlets.data(),
+            },
+        .numElements = meshlets.size(),
+        .dynamic = false,
+        .name = "MeshletBuffer",
+    });
+    vertexIndicesBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
+        .sourceData =
+            {
+                .size = sizeof(uint32) * vertexIndices.size(),
+                .data = (uint8*)vertexIndices.data(),
+            },
+        .numElements = vertexIndices.size(),
+        .dynamic = false,
+        .name = "VertexIndicesBuffer",
+    });
 
-        primitiveIndicesBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
-            .sourceData =
-                {
-                    .size = sizeof(uint8) * primitiveIndices.size(),
-                    .data = (uint8*)primitiveIndices.data(),
-                },
-            .numElements = primitiveIndices.size(),
-            .dynamic = false,
-            .name = "PrimitiveIndicesBuffer",
-        });
+    primitiveIndicesBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
+        .sourceData =
+            {
+                .size = sizeof(uint8) * primitiveIndices.size(),
+                .data = (uint8*)primitiveIndices.data(),
+            },
+        .numElements = primitiveIndices.size(),
+        .dynamic = false,
+        .name = "PrimitiveIndicesBuffer",
+    });
 }
 
 MeshId VertexData::allocateVertexData(uint64 numVertices) {
-        std::unique_lock l(vertexDataLock);
-        MeshId res{idCounter++};
-        meshOffsets.add(head);
-        meshVertexCounts.add(numVertices);
-        meshData.add({});
-        head += numVertices;
-        if (head > verticesAllocated) {
-            verticesAllocated = std::max(head, verticesAllocated + NUM_DEFAULT_ELEMENTS);
-            resizeBuffers();
-        }
-        return res;
+    std::unique_lock l(vertexDataLock);
+    MeshId res{idCounter++};
+    meshOffsets.add(head);
+    meshVertexCounts.add(numVertices);
+    meshData.add({});
+    head += numVertices;
+    if (head > verticesAllocated) {
+        verticesAllocated = std::max(head, verticesAllocated + NUM_DEFAULT_ELEMENTS);
+        resizeBuffers();
+    }
+    return res;
 }
 
-uint64 VertexData::getMeshOffset(MeshId id) {
-        return meshOffsets[id]; }
+uint64 VertexData::getMeshOffset(MeshId id) { return meshOffsets[id]; }
 
-uint64 VertexData::getMeshVertexCount(MeshId id) {
-        return meshVertexCounts[id]; }
+uint64 VertexData::getMeshVertexCount(MeshId id) { return meshVertexCounts[id]; }
 
 List<VertexData*> vertexDataList;
 
-List<VertexData*> VertexData::getList() {
-        return vertexDataList; }
+List<VertexData*> VertexData::getList() { return vertexDataList; }
 
 VertexData* VertexData::findByTypeName(std::string name) {
-        for (auto vd : vertexDataList) {
-            if (vd->getTypeName() == name) {
-                return vd;
-            }
+    for (auto vd : vertexDataList) {
+        if (vd->getTypeName() == name) {
+            return vd;
         }
-        return nullptr;
+    }
+    return nullptr;
 }
 
 void VertexData::init(Gfx::PGraphics _graphics) {
-        graphics = _graphics;
-        verticesAllocated = NUM_DEFAULT_ELEMENTS;
-        instanceDataLayout = graphics->createDescriptorLayout("pScene");
+    graphics = _graphics;
+    verticesAllocated = NUM_DEFAULT_ELEMENTS;
+    instanceDataLayout = graphics->createDescriptorLayout("pScene");
 
-        // instanceData
-        instanceDataLayout->addDescriptorBinding(Gfx::DescriptorBinding{
-            .binding = 0,
-            .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER,
-        });
-        // meshData
-        instanceDataLayout->addDescriptorBinding(Gfx::DescriptorBinding{
-            .binding = 1,
-            .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER,
-        });
-        // meshletData
-        instanceDataLayout->addDescriptorBinding(
-            Gfx::DescriptorBinding{.binding = 2, .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER});
-        // primitiveIndices
-        instanceDataLayout->addDescriptorBinding(
-            Gfx::DescriptorBinding{.binding = 3, .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER});
-        // vertexIndices
-        instanceDataLayout->addDescriptorBinding(
-            Gfx::DescriptorBinding{.binding = 4, .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER});
-        // cullingOffset
-        instanceDataLayout->addDescriptorBinding(
-            Gfx::DescriptorBinding{.binding = 5, .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER});
-        // cullingInfos
-        instanceDataLayout->addDescriptorBinding(
-            Gfx::DescriptorBinding{.binding = 6, .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER});
+    // instanceData
+    instanceDataLayout->addDescriptorBinding(Gfx::DescriptorBinding{
+        .binding = 0,
+        .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER,
+    });
+    // meshData
+    instanceDataLayout->addDescriptorBinding(Gfx::DescriptorBinding{
+        .binding = 1,
+        .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER,
+    });
+    // meshletData
+    instanceDataLayout->addDescriptorBinding(
+        Gfx::DescriptorBinding{.binding = 2, .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER});
+    // primitiveIndices
+    instanceDataLayout->addDescriptorBinding(
+        Gfx::DescriptorBinding{.binding = 3, .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER});
+    // vertexIndices
+    instanceDataLayout->addDescriptorBinding(
+        Gfx::DescriptorBinding{.binding = 4, .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER});
+    // cullingOffset
+    instanceDataLayout->addDescriptorBinding(
+        Gfx::DescriptorBinding{.binding = 5, .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER});
+    // cullingInfos
+    instanceDataLayout->addDescriptorBinding(
+        Gfx::DescriptorBinding{.binding = 6, .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_STORAGE_BUFFER});
 
-        instanceDataLayout->create();
+    instanceDataLayout->create();
 
-        cullingOffsetBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
-            .dynamic = true,
-            .name = "MeshletOffset",
-        });
-        instanceBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
-            .dynamic = true,
-            .name = "InstanceBuffer",
-        });
-        instanceMeshDataBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
-            .dynamic = true,
-            .name = "MeshDataBuffer",
-        });
+    cullingOffsetBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
+        .dynamic = true,
+        .name = "MeshletOffset",
+    });
+    instanceBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
+        .dynamic = true,
+        .name = "InstanceBuffer",
+    });
+    instanceMeshDataBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
+        .dynamic = true,
+        .name = "MeshDataBuffer",
+    });
 
-        transparentInstanceDataBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
-            .dynamic = true,
-            .name = "TransparentInstanceBuffer",
-        });
-        transparentMeshDataBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
-            .dynamic = true,
-            .name = "TransparentMeshBuffer",
-        });
+    transparentInstanceDataBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
+        .dynamic = true,
+        .name = "TransparentInstanceBuffer",
+    });
+    transparentMeshDataBuffer = graphics->createShaderBuffer(ShaderBufferCreateInfo{
+        .dynamic = true,
+        .name = "TransparentMeshBuffer",
+    });
 
-        resizeBuffers();
-        graphics->getShaderCompiler()->registerVertexData(this);
+    resizeBuffers();
+    graphics->getShaderCompiler()->registerVertexData(this);
 }
 
 void VertexData::destroy() {
-        instanceBuffer = nullptr;
-        instanceMeshDataBuffer = nullptr;
-        instanceDataLayout = nullptr;
-        meshletBuffer = nullptr;
-        vertexIndicesBuffer = nullptr;
-        primitiveIndicesBuffer = nullptr;
-        indexBuffer = nullptr;
-        meshData.clear();
-        materialData.clear();
+    instanceBuffer = nullptr;
+    instanceMeshDataBuffer = nullptr;
+    instanceDataLayout = nullptr;
+    meshletBuffer = nullptr;
+    vertexIndicesBuffer = nullptr;
+    primitiveIndicesBuffer = nullptr;
+    indexBuffer = nullptr;
+    meshData.clear();
+    materialData.clear();
 }
 
 VertexData::CullingMapping VertexData::getCullingMapping(entt::entity id, uint32 meshIndex, uint32 numMeshlets) {
-        MeshMapping key = MeshMapping{.id = id, .meshId = meshIndex};
-        if (!instanceIdMap.contains(key)) {
-            instanceIdMap[key] = CullingMapping{.instanceId = instanceCount++, .cullingOffset = uint32(meshletCount)};
-            meshletCount += numMeshlets;
-        }
-        return instanceIdMap[key];
+    MeshMapping key = MeshMapping{.id = id, .meshId = meshIndex};
+    if (!instanceIdMap.contains(key)) {
+        instanceIdMap[key] = CullingMapping{.instanceId = instanceCount++, .cullingOffset = uint32(meshletCount)};
+        meshletCount += numMeshlets;
+    }
+    return instanceIdMap[key];
 }
 
 VertexData::VertexData() : idCounter(0), head(0), verticesAllocated(0), dirty(false) {}

src/Engine/Graphics/Vulkan/Buffer.cpp

@@ -262,8 +262,20 @@ void Buffer::copyBuffer(uint64 src, uint64 dst) {
         .offset = 0,
         .size = buffers[src]->size,
     };
-    vkCmdPipelineBarrier(command->getHandle(), VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT, VK_PIPELINE_STAGE_TRANSFER_BIT, 0, 0, nullptr, 1,
-                         &srcBarrier, 0, nullptr);
+    VkBufferMemoryBarrier clearBarrier = {
+        .sType = VK_STRUCTURE_TYPE_BUFFER_MEMORY_BARRIER,
+        .pNext = nullptr,
+        .srcAccessMask = VK_ACCESS_TRANSFER_WRITE_BIT,
+        .dstAccessMask = VK_ACCESS_TRANSFER_WRITE_BIT,
+        .srcQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED,
+        .dstQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED,
+        .buffer = buffers[dst]->buffer,
+        .offset = 0,
+        .size = buffers[dst]->size,
+    };
+    VkBufferMemoryBarrier srcBarriers[] = {srcBarrier, clearBarrier};
+    vkCmdPipelineBarrier(command->getHandle(), VK_PIPELINE_STAGE_TRANSFER_BIT, VK_PIPELINE_STAGE_TRANSFER_BIT, 0, 0, nullptr, 2,
+                         srcBarriers, 0, nullptr);
     VkBufferCopy region = {
         .srcOffset = 0,
         .dstOffset = 0,

src/Engine/Graphics/Vulkan/Command.cpp

@@ -141,7 +141,6 @@ void Command::checkFence() {
 }
 
 void Command::waitForCommand(uint32 timeout) {
-    pool->submitCommands();
     if (state == State::Begin) {
         // is already done
         return;

src/Engine/Graphics/Vulkan/Graphics.cpp

@@ -46,7 +46,10 @@ void vkCmdDrawMeshTasksIndirectEXT(VkCommandBuffer commandBuffer, VkBuffer buffe
 }
 
 VkResult vkSetDebugUtilsObjectNameEXT(VkDevice device, const VkDebugUtilsObjectNameInfoEXT* pNameInfo) {
-    return setDebugUtilsObjectName(device, pNameInfo);
+    if (setDebugUtilsObjectName != nullptr) {
+        return setDebugUtilsObjectName(device, pNameInfo);
+    }
+    return VK_SUCCESS;
 }
 
 VkResult vkCreateAccelerationStructureKHR(VkDevice device, const VkAccelerationStructureCreateInfoKHR* pCreateInfo,
@@ -139,7 +142,9 @@ void Graphics::beginRenderPass(Gfx::PRenderPass renderPass) {
     getGraphicsCommands()->getCommands()->beginRenderPass(rp, framebuffer);
 }
 
-void Graphics::endRenderPass() { getGraphicsCommands()->getCommands()->endRenderPass(); }
+void Graphics::endRenderPass() {
+    getGraphicsCommands()->getCommands()->endRenderPass();
+}
 
 void Graphics::waitDeviceIdle() { vkDeviceWaitIdle(handle); }
 

src/Engine/Graphics/Vulkan/Query.cpp

@@ -150,14 +150,9 @@ Array<Gfx::Timestamp> TimestampQuery::getResults() {
     tail = (tail + 1) % 512;
     Array<Gfx::Timestamp> res;
     for (uint64 i = 0; i < numTimestamps; ++i) {
-        if (results[i] < lastMeasure)
-        {
-            wrapping += 1ull << graphics->getTimestampValidBits();
-        }
-        lastMeasure = results[i];
         res.add(Gfx::Timestamp{
             .name = pendingTimestamps[firstQuery + i],
-            .time = std::chrono::nanoseconds(uint64((results[i] + wrapping) * graphics->getTimestampPeriod())),
+            .time = uint64((results[i] + wrapping) * graphics->getTimestampPeriod()),
         });
     }
     return res;

src/Engine/Graphics/Vulkan/RenderPass.cpp

@@ -79,7 +79,7 @@ RenderPass::RenderPass(PGraphics graphics, Gfx::RenderTargetLayout _layout, Arra
             .pNext = nullptr,
             .flags = 0,
             .format = cast(resolveAttachment.getFormat()),
-            .samples = (VkSampleCountFlagBits)resolveAttachment.getNumSamples(),
+            .samples = (VkSampleCountFlagBits)resolveAttachment.getTexture()->getNumSamples(),
             .loadOp = cast(resolveAttachment.getLoadOp()),
             .storeOp = cast(resolveAttachment.getStoreOp()),
             .stencilLoadOp = cast(resolveAttachment.getStencilLoadOp()),
@@ -143,6 +143,10 @@ RenderPass::RenderPass(PGraphics graphics, Gfx::RenderTargetLayout _layout, Arra
             .initialLayout = cast(layout.depthResolveAttachment.getInitialLayout()),
             .finalLayout = cast(layout.depthResolveAttachment.getFinalLayout()),
         };
+        VkClearValue& clearValue = clearValues.add();
+        if (attachments.back().loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) {
+            clearValue = cast(layout.depthResolveAttachment.clear);
+        }
         depthResolveRef = {
             .sType = VK_STRUCTURE_TYPE_ATTACHMENT_REFERENCE_2,
             .pNext = nullptr,
@@ -214,14 +218,22 @@ uint32 RenderPass::getFramebufferHash() {
         PTexture2D tex = colorAttachment.getTexture().cast<Texture2D>();
         description.colorAttachments[description.numColorAttachments++] = tex->getView();
     }
+    for (auto& resolveAttachment : layout.resolveAttachments) {
+        PTexture2D tex = resolveAttachment.getTexture().cast<Texture2D>();
+        description.resolveAttachments[description.numResolveAttachments++] = tex->getView(); 
+    }
     if (layout.depthAttachment.getTexture() != nullptr) {
         PTexture2D tex = layout.depthAttachment.getTexture().cast<Texture2D>();
         description.depthAttachment = tex->getView();
     }
+    if (layout.depthResolveAttachment.getTexture() != nullptr) {
+        PTexture2D tex = layout.depthResolveAttachment.getTexture().cast<Texture2D>();
+        description.depthResolveAttachment = tex->getView();
+    }
     return CRC::Calculate(&description, sizeof(FramebufferDescription), CRC::CRC_32());
 }
 
-void Vulkan::RenderPass::endRenderPass() {
+void RenderPass::endRenderPass() {
     for (auto& inputAttachment : layout.inputAttachments) {
         PTexture2D tex = inputAttachment.getTexture().cast<Texture2D>();
         tex->setLayout(inputAttachment.getFinalLayout());
@@ -230,8 +242,16 @@ void Vulkan::RenderPass::endRenderPass() {
         PTexture2D tex = colorAttachment.getTexture().cast<Texture2D>();
         tex->setLayout(colorAttachment.getFinalLayout());
     }
+    for (auto& resolveAttachment : layout.resolveAttachments) {
+        PTexture2D tex = resolveAttachment.getTexture().cast<Texture2D>();
+        tex->setLayout(resolveAttachment.getFinalLayout());
+    }
     if (layout.depthAttachment.getTexture() != nullptr) {
         PTexture2D tex = layout.depthAttachment.getTexture().cast<Texture2D>();
         tex->setLayout(layout.depthAttachment.getFinalLayout());
     }
+    if (layout.depthResolveAttachment.getTexture() != nullptr) {
+        PTexture2D tex = layout.depthResolveAttachment.getTexture().cast<Texture2D>();
+        tex->setLayout(layout.depthResolveAttachment.getFinalLayout());
+    }
 }

src/Engine/Graphics/Vulkan/Texture.cpp

@@ -137,17 +137,6 @@ TextureHandle::TextureHandle(PGraphics graphics, VkImageViewType viewType, const
         changeLayout(Gfx::SE_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL, VK_ACCESS_TRANSFER_WRITE_BIT, VK_PIPELINE_STAGE_TRANSFER_BIT,
                      VK_ACCESS_SHADER_READ_BIT, VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT);
         graphics->getDestructionManager()->queueResourceForDestruction(std::move(stagingAlloc));
-    } else {
-        if (usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) {
-            changeLayout(Gfx::SE_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL, VK_ACCESS_NONE, VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT,
-                         VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT);
-        } else if (usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT) {
-            changeLayout(Gfx::SE_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL, VK_ACCESS_NONE, VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT,
-                         VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT);
-        } else {
-            changeLayout(Gfx::SE_IMAGE_LAYOUT_GENERAL, VK_ACCESS_NONE, VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT, VK_ACCESS_MEMORY_WRITE_BIT,
-                         VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT);
-        }
     }
     VkImageViewCreateInfo viewInfo = {
         .sType = VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO,
@@ -331,7 +320,7 @@ void TextureHandle::generateMipmaps() {
                 .aspectMask = aspect,
                 .levelCount = 1,
                 .baseArrayLayer = 0,
-                .layerCount = 1,
+                .layerCount = layerCount,
             },
     };
     int32 mipWidth = width;

src/Engine/Graphics/Vulkan/Window.cpp

@@ -5,7 +5,6 @@
 #include "Resources.h"
 #include <GLFW/glfw3.h>
 
-
 using namespace Seele;
 using namespace Seele::Vulkan;
 
@@ -93,9 +92,9 @@ void Window::pollInput() { glfwPollEvents(); }
 
 void Window::beginFrame() {
     imageAvailableFences[currentSemaphoreIndex]->reset();
-    vkAcquireNextImageKHR(graphics->getDevice(), swapchain, std::numeric_limits<uint64>::max(),
-                          imageAvailableSemaphores[currentSemaphoreIndex]->getHandle(),
-                          imageAvailableFences[currentSemaphoreIndex]->getHandle(), &currentImageIndex);
+    VK_CHECK(vkAcquireNextImageKHR(graphics->getDevice(), swapchain, std::numeric_limits<uint64>::max(),
+                                   imageAvailableSemaphores[currentSemaphoreIndex]->getHandle(),
+                                   imageAvailableFences[currentSemaphoreIndex]->getHandle(), &currentImageIndex));
     imageAvailableFences[currentSemaphoreIndex]->submit();
     graphics->getGraphicsCommands()->getCommands()->waitForSemaphore(VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT,
                                                                      imageAvailableSemaphores[currentSemaphoreIndex]);

src/Engine/Math/Vector.cpp

@@ -26,15 +26,20 @@ void from_json(const nlohmann::json& j, Vector& vec) {
 }
 
 std::ostream& operator<<(std::ostream& stream, const Vector2& vector) {
-    stream << "(" << vector.x << ", " << vector.y << ")";
+    stream << "Vec2(" << vector.x << ", " << vector.y << ")";
     return stream;
 }
 std::ostream& operator<<(std::ostream& stream, const Vector& vector) {
-    stream << "(" << vector.x << ", " << vector.y << ", " << vector.z << ")";
+    stream << "Vec3(" << vector.x << ", " << vector.y << ", " << vector.z << ")";
     return stream;
 }
 std::ostream& operator<<(std::ostream& stream, const Vector4& vector) {
-    stream << "(" << vector.x << ", " << vector.y << ", " << vector.z << ", " << vector.w << ")";
+    stream << "Vec4(" << vector.x << ", " << vector.y << ", " << vector.z << ", " << vector.w << ")";
+    return stream;
+}
+
+std::ostream& operator<<(std::ostream& stream, const Quaternion& vector) {
+    stream << "Quat(" << vector.w << ", " << vector.x << ", " << vector.y << ", " << vector.z << ")";
     return stream;
 }
 

src/Engine/Math/Vector.h

@@ -37,3 +37,4 @@ void from_json(nlohmann::json& j, Vector& vec);
 std::ostream& operator<<(std::ostream& stream, const Seele::Vector2& vector);
 std::ostream& operator<<(std::ostream& stream, const Seele::Vector& vector);
 std::ostream& operator<<(std::ostream& stream, const Seele::Vector4& vector);
+std::ostream& operator<<(std::ostream& stream, const Seele::Quaternion& vector);

src/Engine/MinimalEngine.h

@@ -142,4 +142,13 @@ template <typename T> class UniquePtr {
   private:
     T* handle;
 };
+
+// idk if it should be here?
+struct Globals {
+    bool usePositionOnly = true;
+    bool useDepthCulling = true;
+    bool useLightCulling = true;
+    bool running = true;
+};
+Globals& getGlobals();
 } // namespace Seele

src/Engine/Scene/LightEnvironment.cpp

@@ -60,11 +60,14 @@ void LightEnvironment::addDirectionalLight(Component::DirectionalLight dirLight)
 void LightEnvironment::addPointLight(Component::PointLight pointLight) { points.add(pointLight); }
 
 void LightEnvironment::commit() {
-    lightEnvBuffer->pipelineBarrier(Gfx::SE_ACCESS_SHADER_READ_BIT, Gfx::SE_PIPELINE_STAGE_ALL_COMMANDS_BIT,
+    lightEnvBuffer->pipelineBarrier(Gfx::SE_ACCESS_UNIFORM_READ_BIT | Gfx::SE_ACCESS_TRANSFER_WRITE_BIT,
+                                    Gfx::SE_PIPELINE_STAGE_ALL_COMMANDS_BIT,
                                     Gfx::SE_ACCESS_TRANSFER_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT);
-    pointLights->pipelineBarrier(Gfx::SE_ACCESS_SHADER_READ_BIT, Gfx::SE_PIPELINE_STAGE_ALL_COMMANDS_BIT, Gfx::SE_ACCESS_TRANSFER_WRITE_BIT,
+    pointLights->pipelineBarrier(Gfx::SE_ACCESS_SHADER_READ_BIT | Gfx::SE_ACCESS_TRANSFER_WRITE_BIT,
+                                 Gfx::SE_PIPELINE_STAGE_ALL_COMMANDS_BIT, Gfx::SE_ACCESS_TRANSFER_WRITE_BIT,
                                  Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT);
-    directionalLights->pipelineBarrier(Gfx::SE_ACCESS_SHADER_READ_BIT, Gfx::SE_PIPELINE_STAGE_ALL_COMMANDS_BIT,
+    directionalLights->pipelineBarrier(Gfx::SE_ACCESS_SHADER_READ_BIT | Gfx::SE_ACCESS_TRANSFER_WRITE_BIT,
+                                       Gfx::SE_PIPELINE_STAGE_ALL_COMMANDS_BIT,
                                        Gfx::SE_ACCESS_TRANSFER_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT);
     lightEnv.numDirectionalLights = dirs.size();
     lightEnv.numPointLights = points.size();
@@ -87,7 +90,7 @@ void LightEnvironment::commit() {
         .numElements = points.size(),
     });
 
-    lightEnvBuffer->pipelineBarrier(Gfx::SE_ACCESS_TRANSFER_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT, Gfx::SE_ACCESS_SHADER_READ_BIT,
+    lightEnvBuffer->pipelineBarrier(Gfx::SE_ACCESS_TRANSFER_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT, Gfx::SE_ACCESS_UNIFORM_READ_BIT,
                                     Gfx::SE_PIPELINE_STAGE_ALL_COMMANDS_BIT);
     pointLights->pipelineBarrier(Gfx::SE_ACCESS_TRANSFER_WRITE_BIT, Gfx::SE_PIPELINE_STAGE_TRANSFER_BIT, Gfx::SE_ACCESS_SHADER_READ_BIT,
                                  Gfx::SE_PIPELINE_STAGE_ALL_COMMANDS_BIT);

src/Engine/ThreadPool.cpp

@@ -1,7 +1,12 @@
 #include "ThreadPool.h"
+#include "MinimalEngine.h"
 
 using namespace Seele;
 
+Globals globals;
+
+Globals& Seele::getGlobals() { return globals; }
+
 ThreadPool::ThreadPool(uint32 numWorkers) {
     for (uint32 i = 0; i < numWorkers; ++i) {
         workers.add(std::thread(&ThreadPool::work, this));

src/Engine/ThreadPool.h

@@ -4,7 +4,6 @@
 #include <functional>
 #include <thread>
 
-
 namespace Seele {
 class ThreadPool {
   public:

src/Engine/Window/GameView.cpp

@@ -6,24 +6,19 @@
 #include "Graphics/Query.h"
 #include "Graphics/RenderPass/BasePass.h"
 #include "Graphics/RenderPass/CachedDepthPass.h"
-#include "Graphics/RenderPass/DebugPass.h"
 #include "Graphics/RenderPass/DepthCullingPass.h"
 #include "Graphics/RenderPass/LightCullingPass.h"
 #include "Graphics/RenderPass/RenderGraphResources.h"
-#include "Graphics/RenderPass/SkyboxRenderPass.h"
 #include "Graphics/RenderPass/VisibilityPass.h"
 #include "System/CameraUpdater.h"
 #include "System/LightGather.h"
 #include "System/MeshUpdater.h"
 #include "Window/Window.h"
 #include <fstream>
+#include <thread>
 
 using namespace Seele;
 
-bool usePositionOnly = false;
-bool useDepthCulling = false;
-bool useLightCulling = false;
-
 GameView::GameView(Gfx::PGraphics graphics, PWindow window, const ViewportCreateInfo& createInfo, std::string dllPath)
     : View(graphics, window, createInfo, "Game"), scene(new Scene(graphics)), gameInterface(dllPath) {
     reloadGame();
@@ -32,48 +27,8 @@ GameView::GameView(Gfx::PGraphics graphics, PWindow window, const ViewportCreate
     renderGraph.addPass(new VisibilityPass(graphics, scene));
     renderGraph.addPass(new LightCullingPass(graphics, scene));
     renderGraph.addPass(new BasePass(graphics, scene));
-    renderGraph.addPass(new DebugPass(graphics, scene));
-    //    renderGraph.addPass(new SkyboxRenderPass(graphics, scene));
     renderGraph.setViewport(viewport);
     renderGraph.createRenderPass();
-    queryThread = std::thread([&]() {
-        PRenderGraphResources res = renderGraph.getResources();
-        Gfx::PPipelineStatisticsQuery cachedQuery = res->requestQuery("CACHED_QUERY");
-        Gfx::PPipelineStatisticsQuery depthQuery = res->requestQuery("DEPTH_QUERY");
-        Gfx::PPipelineStatisticsQuery baseQuery = res->requestQuery("BASEPASS_QUERY");
-        Gfx::PPipelineStatisticsQuery lightCullQuery = res->requestQuery("LIGHTCULL_QUERY");
-        Gfx::PPipelineStatisticsQuery visibilityQuery = res->requestQuery("VISIBILITY_QUERY");
-        Gfx::PTimestampQuery timeQuery = res->requestTimestampQuery("TIMESTAMP");
-        std::ofstream stats("stats.csv");
-        stats << "RelTime,"
-              << "CachedIAV,CachedIAP,CachedVS,CachedClipInv,CachedClipPrim,CachedFS,CachedCS,CachedTS,CachedMS,"
-              << "DepthIAV,DepthIAP,DepthVS,DepthClipInv,DepthClipPrim,DepthFS,DepthCS,DepthTS,DepthMS,"
-              << "BaseIAV,BaseIAP,BaseVS,BaseClipInv,BaseClipPrim,BaseFS,BaseCS,BaseTS,BaseMS,"
-              << "LightCullIAV,LightCullIAP,LightCullVS,LightCullClipInv,LightCullClipPrim,LightCullFS,LightCullCS,LightCullTS,LightCullMS,"
-              << "VisibilityIAV,VisibilityIAP,VisibilityVS,VisibilityClipInv,VisibilityClipPrim,VisibilityFS,VisibilityCS,VisibilityTS,"
-                 "VisibilityMS,"
-              << "CACHED,MIPGEN,DEPTHCULL,VISIBILITY,LIGHTCULL,BASE" << std::endl;
-        std::chrono::nanoseconds start = std::chrono::nanoseconds(0);
-        while (true) {
-            auto timestamps = timeQuery->getResults();
-            auto cachedResults = cachedQuery->getResults();
-            auto depthResults = depthQuery->getResults();
-            auto baseResults = baseQuery->getResults();
-            auto lightCullResults = lightCullQuery->getResults();
-            auto visiblityResults = visibilityQuery->getResults();
-            if (start.count() == 0) {
-                start = timestamps[0].time;
-            }
-            stats << (timestamps[0].time - start).count() << "," << cachedResults << depthResults << baseResults << lightCullResults
-                  << visiblityResults;
-            stats << fmt::format("{},{},{},{},{},{}", (timestamps[1].time - timestamps[0].time).count(),
-                                 (timestamps[2].time - timestamps[1].time).count(), (timestamps[3].time - timestamps[2].time).count(),
-                                 (timestamps[4].time - timestamps[3].time).count(), (timestamps[5].time - timestamps[4].time).count(),
-                                 (timestamps[6].time - timestamps[5].time).count())
-                  << std::endl;
-            stats.flush();
-        }
-    });
 }
 
 GameView::~GameView() {}
@@ -127,18 +82,6 @@ void GameView::reloadGame() {
 
 void GameView::keyCallback(KeyCode code, InputAction action, KeyModifier modifier) {
     keyboardSystem->keyCallback(code, action, modifier);
-    if (code == KeyCode::KEY_P && action == InputAction::RELEASE) {
-        usePositionOnly = !usePositionOnly;
-        std::cout << "Use Pos only " << usePositionOnly << std::endl;
-    }
-    if (code == KeyCode::KEY_O && action == InputAction::RELEASE) {
-        useDepthCulling = !useDepthCulling;
-        std::cout << "Use Depth Culling " << useDepthCulling << std::endl;
-    }
-    if (code == KeyCode::KEY_L && action == InputAction::RELEASE) {
-        useLightCulling = !useLightCulling;
-        std::cout << "Use Light Culling " << useLightCulling << std::endl;
-    }
 }
 
 void GameView::mouseMoveCallback(double xPos, double yPos) { keyboardSystem->mouseCallback(xPos, yPos); }

src/Engine/Window/GameView.h

@@ -28,7 +28,6 @@ class GameView : public View {
     OScene scene;
     GameInterface gameInterface;
     RenderGraph renderGraph;
-    std::thread queryThread;
 
     PSystemGraph systemGraph;
     System::PKeyboardInput keyboardSystem;