Some actually useful metal changes???

src/Engine/Graphics/RenderPass/BasePass.cpp

@@ -99,7 +99,7 @@ void BasePass::beginFrame(const Component::Camera& cam) {
     transparentCulling = lightCullingLayout->allocateDescriptorSet();
 
     //waterRenderer->beginFrame();
-    terrainRenderer->beginFrame(viewParamsSet, cam);
+    //terrainRenderer->beginFrame(viewParamsSet, cam);
 
     // Debug vertices
     {
@@ -249,7 +249,7 @@ void BasePass::render() {
     }
     
     //commands.add(waterRenderer->render(viewParamsSet));
-    commands.add(terrainRenderer->render(viewParamsSet));
+    //commands.add(terrainRenderer->render(viewParamsSet));
     
     // Skybox
     {
@@ -432,7 +432,7 @@ void BasePass::publishOutputs() {
 
 void BasePass::createRenderPass() {
     RenderPass::beginFrame(Component::Camera());
-    terrainRenderer = new TerrainRenderer(graphics, scene, viewParamsLayout, viewParamsSet);
+    //terrainRenderer = new TerrainRenderer(graphics, scene, viewParamsLayout, viewParamsSet);
     cullingBuffer = resources->requestBuffer("CULLINGBUFFER");
     timestamps = resources->requestTimestampQuery("TIMESTAMPS");
 
@@ -475,7 +475,7 @@ void BasePass::createRenderPass() {
     tLightGrid = resources->requestTexture("LIGHTCULLING_TLIGHTGRID");
 
     //waterRenderer->setViewport(viewport, renderPass);
-    terrainRenderer->setViewport(viewport, renderPass);
+    //terrainRenderer->setViewport(viewport, renderPass);
 
     // Debug rendering
     {
@@ -552,6 +552,7 @@ void BasePass::createRenderPass() {
         skyboxDataLayout->addDescriptorBinding(Gfx::DescriptorBinding{
             .binding = 0,
             .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
+            .uniformLength = sizeof(SkyboxData)
         });
         skyboxDataLayout->create();
         textureLayout = graphics->createDescriptorLayout("pSkyboxTextures");

src/Engine/Graphics/RenderPass/CachedDepthPass.cpp

@@ -105,9 +105,11 @@ void CachedDepthPass::render() {
             command->bindPipeline(pipeline);
         }
         command->bindDescriptor({viewParamsSet, vertexData->getVertexDataSet(), vertexData->getInstanceDataSet()});
-        uint32 offset = 0;
+        VertexData::DrawCallOffsets offsets = {
+            .instanceOffset = 0,
+        };
         command->pushConstants(Gfx::SE_SHADER_STAGE_TASK_BIT_EXT | Gfx::SE_SHADER_STAGE_VERTEX_BIT, 0, sizeof(VertexData::DrawCallOffsets),
-                               &offset);
+                               &offsets);
         if (graphics->supportMeshShading()) {
             command->drawMesh(vertexData->getNumInstances(), 1, 1);
         } else {

src/Engine/Graphics/RenderPass/LightCullingPass.cpp

@@ -248,6 +248,7 @@ void LightCullingPass::setupFrustums() {
     dispatchParamsLayout->addDescriptorBinding(Gfx::DescriptorBinding{
         .binding = 0,
         .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
+        .uniformLength = sizeof(DispatchParams),
     });
     dispatchParamsLayout->addDescriptorBinding(Gfx::DescriptorBinding{
         .binding = 1,

src/Engine/Graphics/RenderPass/RenderPass.cpp

@@ -7,6 +7,7 @@ RenderPass::RenderPass(Gfx::PGraphics graphics, PScene scene) : graphics(graphic
     viewParamsLayout->addDescriptorBinding(Gfx::DescriptorBinding{
         .binding = 0,
         .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
+        .uniformLength = sizeof(ViewParameter),
     });
     UniformBufferCreateInfo uniformInitializer = {
         .sourceData =
@@ -129,4 +130,4 @@ void RenderPass::extract_planes_from_view_projection_matrix(const Matrix4 viewPr
     // Normalize all the planes
     for (uint32_t planeIdx = 0; planeIdx < 4; ++planeIdx)
         normalize_plane(frustum.planes[planeIdx]);
-}
+}

src/Engine/Graphics/RenderPass/TextPass.cpp

@@ -105,6 +105,7 @@ void TextPass::createRenderPass() {
     generalLayout->addDescriptorBinding(Gfx::DescriptorBinding{
         .binding = 0,
         .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
+        .uniformLength = sizeof(Matrix4),
     });
     generalLayout->addDescriptorBinding(Gfx::DescriptorBinding{
         .binding = 1,

src/Engine/Graphics/RenderPass/UIPass.cpp

@@ -99,6 +99,7 @@ void UIPass::createRenderPass() {
     descriptorLayout->addDescriptorBinding(Gfx::DescriptorBinding{
         .binding = 0,
         .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
+        .uniformLength = sizeof(Matrix4),
     });
     descriptorLayout->addDescriptorBinding(Gfx::DescriptorBinding{
         .binding = 1,
@@ -107,6 +108,7 @@ void UIPass::createRenderPass() {
     descriptorLayout->addDescriptorBinding(Gfx::DescriptorBinding{
         .binding = 2,
         .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
+        .uniformLength = sizeof(uint32)
     });
     descriptorLayout->addDescriptorBinding(Gfx::DescriptorBinding{
         .binding = 3,

src/Engine/Graphics/RenderPass/WaterRenderer.cpp

@@ -124,6 +124,7 @@ WaterRenderer::WaterRenderer(Gfx::PGraphics graphics, PScene scene, Gfx::PDescri
     computeLayout->addDescriptorBinding(Gfx::DescriptorBinding{
         .binding = 0,
         .descriptorType = Gfx::SE_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
+        .uniformLength = sizeof(MaterialParams),
     });
     computeLayout->addDescriptorBinding(Gfx::DescriptorBinding{
         .binding = 1,